Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 682833003: AXRoleDescription is not exposed correctly for aside, main, nav element (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

AXRoleDescription is not exposed correctly for aside, main, nav element According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html HTML Element AXRoleDescription aside complementary main main nav navigation BUG=281895 Committed: https://crrev.com/e55306defdc23e95b7d3cf91c8d344dbc31c9f61 Cr-Commit-Position: refs/heads/master@{#302991}

Patch Set 1 #

Patch Set 2 : adding change for main and nav element #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : Incorporated comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -34 lines) Patch
M content/app/strings/content_strings.grd View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 1 chunk +9 lines, -1 line 0 comments Download
M content/test/data/accessibility/aside-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/landmark.html View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/landmark-expected-mac.txt View 1 1 chunk +27 lines, -27 lines 0 comments Download
M content/test/data/accessibility/main.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/main-expected-mac.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/navigation-expected-mac.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
shreeramk
@Dominic: PTAL. Thanks @Avi & @Dominic: Please give your review points for the changes in ...
6 years, 1 month ago (2014-11-05 16:05:38 UTC) #2
dmazzoni
https://codereview.chromium.org/682833003/diff/60001/content/app/strings/content_strings.grd File content/app/strings/content_strings.grd (right): https://codereview.chromium.org/682833003/diff/60001/content/app/strings/content_strings.grd#newcode342 content/app/strings/content_strings.grd:342: complementary The text of the string to be translated ...
6 years, 1 month ago (2014-11-05 16:20:28 UTC) #3
Avi (use Gerrit)
LGTM for when dmazzoni is happy
6 years, 1 month ago (2014-11-05 16:42:25 UTC) #4
shreeramk
On 2014/11/05 16:20:28, dmazzoni wrote: > https://codereview.chromium.org/682833003/diff/60001/content/app/strings/content_strings.grd > File content/app/strings/content_strings.grd (right): > > https://codereview.chromium.org/682833003/diff/60001/content/app/strings/content_strings.grd#newcode342 > ...
6 years, 1 month ago (2014-11-05 19:10:44 UTC) #5
dmazzoni
lgtm
6 years, 1 month ago (2014-11-06 07:11:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682833003/80001
6 years, 1 month ago (2014-11-06 07:47:34 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-06 09:03:09 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 09:03:44 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e55306defdc23e95b7d3cf91c8d344dbc31c9f61
Cr-Commit-Position: refs/heads/master@{#302991}

Powered by Google App Engine
This is Rietveld 408576698