Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 682833003: AXRoleDescription is not exposed correctly for aside, main, nav element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <execinfo.h> 5 #include <execinfo.h>
6 6
7 #import "content/browser/accessibility/browser_accessibility_cocoa.h" 7 #import "content/browser/accessibility/browser_accessibility_cocoa.h"
8 8
9 #include <map> 9 #include <map>
10 10
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 // TODO(dtseng): This is not localized; see crbug/84814. 577 // TODO(dtseng): This is not localized; see crbug/84814.
578 return base::SysUTF8ToNSString(role); 578 return base::SysUTF8ToNSString(role);
579 } 579 }
580 } 580 }
581 } 581 }
582 582
583 switch([self internalRole]) { 583 switch([self internalRole]) {
584 case ui::AX_ROLE_ARTICLE: 584 case ui::AX_ROLE_ARTICLE:
585 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 585 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
586 IDS_AX_ROLE_ARTICLE)); 586 IDS_AX_ROLE_ARTICLE));
587 break;
588 case ui::AX_ROLE_BANNER: 587 case ui::AX_ROLE_BANNER:
589 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 588 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
590 IDS_AX_ROLE_BANNER)); 589 IDS_AX_ROLE_BANNER));
590 case ui::AX_ROLE_COMPLEMENTARY:
591 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
592 IDS_AX_ROLE_COMPLEMENTARY));
591 case ui::AX_ROLE_CONTENT_INFO: 593 case ui::AX_ROLE_CONTENT_INFO:
592 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 594 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
593 IDS_AX_ROLE_ADDRESS)); 595 IDS_AX_ROLE_ADDRESS));
594 case ui::AX_ROLE_FOOTER: 596 case ui::AX_ROLE_FOOTER:
595 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 597 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
596 IDS_AX_ROLE_FOOTER)); 598 IDS_AX_ROLE_FOOTER));
599 case ui::AX_ROLE_MAIN:
600 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
601 IDS_AX_ROLE_MAIN_CONTENT));
602 case ui::AX_ROLE_NAVIGATION:
603 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
604 IDS_AX_ROLE_NAVIGATIONAL_LINK));
597 case ui::AX_ROLE_REGION: 605 case ui::AX_ROLE_REGION:
598 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 606 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
599 IDS_AX_ROLE_REGION)); 607 IDS_AX_ROLE_REGION));
600 case ui::AX_ROLE_SPIN_BUTTON: 608 case ui::AX_ROLE_SPIN_BUTTON:
601 // This control is similar to what VoiceOver calls a "stepper". 609 // This control is similar to what VoiceOver calls a "stepper".
602 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 610 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
603 IDS_AX_ROLE_STEPPER)); 611 IDS_AX_ROLE_STEPPER));
604 case ui::AX_ROLE_TOGGLE_BUTTON: 612 case ui::AX_ROLE_TOGGLE_BUTTON:
605 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 613 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
606 IDS_AX_ROLE_TOGGLE_BUTTON)); 614 IDS_AX_ROLE_TOGGLE_BUTTON));
(...skipping 859 matching lines...) Expand 10 before | Expand all | Expand 10 after
1466 return [super hash]; 1474 return [super hash];
1467 return browserAccessibility_->GetId(); 1475 return browserAccessibility_->GetId();
1468 } 1476 }
1469 1477
1470 - (BOOL)accessibilityShouldUseUniqueId { 1478 - (BOOL)accessibilityShouldUseUniqueId {
1471 return YES; 1479 return YES;
1472 } 1480 }
1473 1481
1474 @end 1482 @end
1475 1483
OLDNEW
« no previous file with comments | « content/app/strings/content_strings.grd ('k') | content/test/data/accessibility/aside-expected-mac.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698