Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 682793003: Revert of Optimize QuadF's PointIsInTriangle function (Closed)

Created:
6 years, 1 month ago by danakj
Modified:
6 years, 1 month ago
Reviewers:
kui.zheng
CC:
chromium-reviews, enne (OOO)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Optimize QuadF's PointIsInTriangle function (patchset #3 id:40001 of https://codereview.chromium.org/458173002/) Reason for revert: Caused perf regressions: https://code.google.com/p/chromium/issues/detail?id=404968 Original issue's description: > Optimize QuadF's PointIsInTriangle function > > PointIsInTriangle() is still the hotspot of many CSS animation cases.Take Nexus10 with latest chromium build for example: > 4.0% case: poster-circle.html > 1.5% case: morphing-cubes.html > > This patch changes the algorithm of testing "Point In Triangle". > 1. Using double-precision float point. > 2. A much readable algorithm. > 3. Better performance due to remove 2 div operation > > R=danakj@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290290 TBR=kui.zheng@arm.com NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9ab9844c93996eb2aafaaa0b653dcfa76ba9f340 Cr-Commit-Position: refs/heads/master@{#301455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M ui/gfx/geometry/quad_f.cc View 1 chunk +16 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
Created Revert of Optimize QuadF's PointIsInTriangle function
6 years, 1 month ago (2014-10-27 21:44:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682793003/1
6 years, 1 month ago (2014-10-27 21:47:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 21:53:44 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 21:54:29 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ab9844c93996eb2aafaaa0b653dcfa76ba9f340
Cr-Commit-Position: refs/heads/master@{#301455}

Powered by Google App Engine
This is Rietveld 408576698