Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 682663002: Fix 'chrome://settings/searchEngines' regression. (Closed)

Created:
6 years, 1 month ago by bondd
Modified:
6 years, 1 month ago
Reviewers:
*Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix 'chrome://settings/searchEngines' regression. Fix for URL text selection regression in 'chrome://settings/searchEngines'. BUG=427385 Committed: https://crrev.com/ffac861e0707ebac026d5f29cd7e39eff3bc7cfb Cr-Commit-Position: refs/heads/master@{#301421}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment requested by reviewer dbeam@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/options/inline_editable_list.js View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
Dan Beam
so is this functionally a revert or in general how does this fix the problem? ...
6 years, 1 month ago (2014-10-27 16:17:46 UTC) #3
Dan Beam
oh, sorry, didn't see you hadn't published yet. can wait to review until you're ready.
6 years, 1 month ago (2014-10-27 16:19:19 UTC) #4
bondd
On 2014/10/27 16:17:46, Dan Beam wrote: > so is this functionally a revert or in ...
6 years, 1 month ago (2014-10-27 16:49:34 UTC) #5
bondd
6 years, 1 month ago (2014-10-27 16:49:46 UTC) #6
Dan Beam
On 2014/10/27 16:49:34, bondd wrote: > On 2014/10/27 16:17:46, Dan Beam wrote: > > so ...
6 years, 1 month ago (2014-10-27 18:33:06 UTC) #7
Dan Beam
lgtm https://codereview.chromium.org/682663002/diff/1/chrome/browser/resources/options/inline_editable_list.js File chrome/browser/resources/options/inline_editable_list.js (right): https://codereview.chromium.org/682663002/diff/1/chrome/browser/resources/options/inline_editable_list.js#newcode431 chrome/browser/resources/options/inline_editable_list.js:431: this.tabIndex = -1; nit: // <list> isn't focusable ...
6 years, 1 month ago (2014-10-27 18:35:00 UTC) #8
bondd
https://codereview.chromium.org/682663002/diff/1/chrome/browser/resources/options/inline_editable_list.js File chrome/browser/resources/options/inline_editable_list.js (right): https://codereview.chromium.org/682663002/diff/1/chrome/browser/resources/options/inline_editable_list.js#newcode431 chrome/browser/resources/options/inline_editable_list.js:431: this.tabIndex = -1; On 2014/10/27 18:35:00, Dan Beam wrote: ...
6 years, 1 month ago (2014-10-27 18:46:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682663002/20001
6 years, 1 month ago (2014-10-27 18:47:29 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 19:55:45 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:56:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ffac861e0707ebac026d5f29cd7e39eff3bc7cfb
Cr-Commit-Position: refs/heads/master@{#301421}

Powered by Google App Engine
This is Rietveld 408576698