chrome/browser/resources/options/inline_editable_list.js - Issue 682663002: Fix 'chrome://settings/searchEngines' regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/inline_editable_list.js

Issue 682663002: Fix 'chrome://settings/searchEngines' regression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment requested by reviewer dbeam@ Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options/inline_editable_list.js

diff --git a/chrome/browser/resources/options/inline_editable_list.js b/chrome/browser/resources/options/inline_editable_list.js

index de5b5b42e8d62b47c59424019bd28fff7912af79..1461fca292fefed6a6ae4b729d459018957307b9 100644

--- a/chrome/browser/resources/options/inline_editable_list.js

+++ b/chrome/browser/resources/options/inline_editable_list.js

@@ -428,7 +428,9 @@ cr.define('options', function() {

this.setAttribute('inlineeditable', '');

this.addEventListener('hasElementFocusChange',

this.handleListFocusChange_);

- this.removeAttribute('tabindex');

+ // <list> isn't focusable by default, but cr.ui.List defaults tabindex to

+ // 0 if it's not set.

+ this.tabIndex = -1;

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »