Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 68263024: [ash] Preferred size of ShelfView is not fixed when item is animating (Closed)

Created:
7 years, 1 month ago by simonhong
Modified:
7 years, 1 month ago
Reviewers:
xiyuan, James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, hyojun.im_lge.com
Visibility:
Public.

Description

[ash] Preferred size of ShelfView is not fixed when item is animating Problem: When an item is dragged in overflow bubble to left or right, item and bubble are flickered. The reason for this is preferred shelf view size is based on item's bounds which is not a fixed value when it is in animating. Instead, ideal bounds is more better to get the shelf view's preferred size. R=xiyuan@chromium.org, jamescook@chromium.org BUG=316101 TEST=visual test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/shelf/shelf_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
simonhong
Dear xiyuan, Please take a look.
7 years, 1 month ago (2013-11-15 08:14:30 UTC) #1
xiyuan
lgtm
7 years, 1 month ago (2013-11-15 19:17:27 UTC) #2
simonhong
Dear james, I need owners check.
7 years, 1 month ago (2013-11-15 19:23:12 UTC) #3
James Cook
lgtm
7 years, 1 month ago (2013-11-15 20:33:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/68263024/1
7 years, 1 month ago (2013-11-15 22:09:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/68263024/1
7 years, 1 month ago (2013-11-16 00:39:51 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 06:15:44 UTC) #7
Message was sent while issue was closed.
Change committed as 235640

Powered by Google App Engine
This is Rietveld 408576698