ash/shelf/shelf_view.cc - Issue 68263024: [ash] Preferred size of ShelfView is not fixed when item is animating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_view.cc

Issue 68263024: [ash] Preferred size of ShelfView is not fixed when item is animating (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shelf/shelf_view.cc

diff --git a/ash/shelf/shelf_view.cc b/ash/shelf/shelf_view.cc

index d13f70cc7d534425930baa10233763fc4c98cb0b..61f61d93609fcf123506a951c5c39af0e4a5e33b 100644

--- a/ash/shelf/shelf_view.cc

+++ b/ash/shelf/shelf_view.cc

@@ -1381,7 +1381,7 @@ gfx::Size ShelfView::GetPreferredSize() {

const gfx::Rect last_button_bounds =

last_button_index >= first_visible_index_ ?

- view_model_->view_at(last_button_index)->bounds() :

+ view_model_->ideal_bounds(last_button_index) :

gfx::Rect(gfx::Size(preferred_size, preferred_size));

if (layout_manager_->IsHorizontalAlignment()) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »