Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 68263018: [CSS Shapes] Empty polygons with non-zero shape-padding cause an ASSERT crash (Closed)

Created:
7 years, 1 month ago by Hans Muller
Modified:
7 years, 1 month ago
Reviewers:
eseidel
CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Shapes] Empty polygons with non-zero shape-padding cause an ASSERT crash PolygonShape::shapePaddingBounds() and PolygonShape::shapeMarginBounds() no longer attempt to compute a new FloatPolygon when the original is empty, i.e. when it has less than three vertices. This patch fixes the clusterfuzz failure reported here: https://code.google.com/p/chromium/issues/detail?id=314402 BUG=319069, 314402 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161996

Patch Set 1 #

Patch Set 2 : Corrected the shape-outside test #

Patch Set 3 : Removed extra shape-outside test file #

Messages

Total messages: 7 (0 generated)
Hans Muller
I've fixed the crash reported by clusterfuzz https://code.google.com/p/chromium/issues/detail?id=314402
7 years, 1 month ago (2013-11-14 03:30:01 UTC) #1
eseidel
lgtm
7 years, 1 month ago (2013-11-14 04:09:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hmuller@adobe.com/68263018/60001
7 years, 1 month ago (2013-11-14 04:10:20 UTC) #3
eseidel
You can list multiple numbers on the BUG= line and then the bug bot will ...
7 years, 1 month ago (2013-11-14 04:10:36 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 1 month ago (2013-11-14 06:34:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hmuller@adobe.com/68263018/60001
7 years, 1 month ago (2013-11-14 06:37:55 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 06:38:59 UTC) #7
Message was sent while issue was closed.
Change committed as 161996

Powered by Google App Engine
This is Rietveld 408576698