Issue 6825063: Patch for bug 74983 (among others) to be applied to M11 696 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6825063: Patch for bug 74983 (among others) to be applied to M11 696 branch. (Closed)

Created:
9 years, 8 months ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Scott Byer

CC:
chromium-reviews, karen

Base URL:
svn://svn.chromium.org/chrome/branches/696/src

Visibility:
Public.

Description

Patch for bug 74983 (among others) to be applied to M11 696 branch. Incorporates: http://codereview.chromium.org/6660001 http://codereview.chromium.org/6670081 http://codereview.chromium.org/6697020 http://codereview.chromium.org/6722032 http://codereview.chromium.org/6731064 BUG=54822, 69641, 71695, 74983, 77064, 77217, 77391 TEST=Build and see bugs. Particularly 74983. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81212

Patch Set 1 #

Patch Set 2 : fix up small merge issue found by trybots #

Patch Set 3 : intentionally disabled mac tests. tested by hand. #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1936 lines, -1743 lines)			Patch
D	chrome/browser/file_path_watcher/file_path_watcher.h	View		1 chunk	+0 lines, -68 lines	0 comments	Download
D	chrome/browser/file_path_watcher/file_path_watcher.cc	View		1 chunk	+0 lines, -19 lines	0 comments	Download
D	chrome/browser/file_path_watcher/file_path_watcher_browsertest.cc	View		1 chunk	+0 lines, -454 lines	0 comments	Download
D	chrome/browser/file_path_watcher/file_path_watcher_inotify.cc	View		1 chunk	+0 lines, -413 lines	0 comments	Download
D	chrome/browser/file_path_watcher/file_path_watcher_mac.cc	View		1 chunk	+0 lines, -234 lines	0 comments	Download
D	chrome/browser/file_path_watcher/file_path_watcher_stub.cc	View		1 chunk	+0 lines, -19 lines	0 comments	Download
D	chrome/browser/file_path_watcher/file_path_watcher_win.cc	View		1 chunk	+0 lines, -244 lines	0 comments	Download
M	chrome/browser/policy/file_based_policy_loader.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/file_based_policy_loader.cc	View		4 chunks	+13 lines, -10 lines	0 comments	Download
M	chrome/browser/user_style_sheet_watcher.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/user_style_sheet_watcher.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/user_style_sheet_watcher_unittest.cc	View		2 chunks	+15 lines, -8 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		3 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/chrome_common.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		2 chunks	+1 line, -1 line	0 comments	Download
A	chrome/common/launchd_mac.h	View		1 chunk	+100 lines, -0 lines	0 comments	Download
A	chrome/common/launchd_mac.mm	View		1 chunk	+171 lines, -0 lines	0 comments	Download
M	chrome/common/service_process_util.h	View		5 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/common/service_process_util.cc	View		2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/common/service_process_util_mac.mm	View		9 chunks	+194 lines, -52 lines	0 comments	Download
M	chrome/common/service_process_util_posix.h	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/common/service_process_util_posix.cc	View	1	5 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/common/service_process_util_unittest.cc	View	1 2	8 chunks	+347 lines, -22 lines	0 comments	Download
M	chrome/common/service_process_util_win.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/service/service_main.cc	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/service/service_process.h	View		4 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/service/service_process.cc	View		6 chunks	+14 lines, -6 lines	0 comments	Download
M	chrome/service/service_process_unittest.cc	View		5 chunks	+10 lines, -5 lines	0 comments	Download
M	content/browser/plugin_service.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/plugin_service.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
A	content/common/file_path_watcher/file_path_watcher.h	View		1 chunk	+122 lines, -0 lines	0 comments	Download
A	content/common/file_path_watcher/file_path_watcher.cc	View		1 chunk	+27 lines, -0 lines	0 comments	Download
A +	content/common/file_path_watcher/file_path_watcher_browsertest.cc	View		12 chunks	+247 lines, -85 lines	0 comments	Download
A +	content/common/file_path_watcher/file_path_watcher_inotify.cc	View		9 chunks	+75 lines, -32 lines	0 comments	Download
A	content/common/file_path_watcher/file_path_watcher_mac.cc	View		1 chunk	+487 lines, -0 lines	0 comments	Download
A +	content/common/file_path_watcher/file_path_watcher_stub.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download
A +	content/common/file_path_watcher/file_path_watcher_win.cc	View		7 chunks	+46 lines, -16 lines	0 comments	Download
M	content/content_common.gypi	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	tools/valgrind/tsan/suppressions.txt	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages