Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 6825017: Removed HOTPLUG=1 from the monitor hotplug rules. (Closed)

Created:
9 years, 8 months ago by diandersAtChromium
Modified:
9 years, 6 months ago
Reviewers:
bfreed
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Removed HOTPLUG=1 from the monitor hotplug rules. Since udev didn't understand this key, it wasn't using it anyway. This gets rid of the confusing error message in /var/log/messages. BUG=chromium-os:13694 TEST=Plugged/unplugged a VGA monitor and made sure modes still switched. ...also, built with FEATURES=keepwork and checked this file: /build/x86-mario/tmp/portage/sys-fs/udev-151-r6/work/udev-151/udev/udev-rules.c ...validated that the unknown key was actually being ignored by udev, so this doesn't change behavior (other than getting rid of the error message). Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c02c806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M 99-monitor-hotplug.rules View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
diandersAtChromium
Bryan, This looks like it should get rid of the error message. I'm about 99% ...
9 years, 8 months ago (2011-04-08 22:53:11 UTC) #1
bfreed
9 years, 8 months ago (2011-04-09 07:26:49 UTC) #2
LGTM.

bryan.

Powered by Google App Engine
This is Rietveld 408576698