Source/core/inspector/InspectorDOMAgent.h - Issue 682423002: Devtools Animations: Show subtree animations for a given node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDOMAgent.h

Issue 682423002: Devtools Animations: Show subtree animations for a given node (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Collapse animation sections if there are a lot Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/inspector/InspectorAnimationAgent.cpp ('k') | Source/devtools/front_end/common/Settings.js » ('j') | Source/devtools/front_end/elements/AnimationsSidebarPane.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDOMAgent.h

diff --git a/Source/core/inspector/InspectorDOMAgent.h b/Source/core/inspector/InspectorDOMAgent.h

index 3dfe8ce37e74da877df2eb74c9d18349c39ae024..1682d7ff4efec36c9da74cab38acd558675b6970 100644

--- a/Source/core/inspector/InspectorDOMAgent.h

+++ b/Source/core/inspector/InspectorDOMAgent.h

@@ -187,6 +187,7 @@ public:

Node* nodeForId(int nodeId);

int boundNodeId(Node*);

void setDOMListener(DOMListener*);

+ int pushNodePathToFrontend(Node*);

vsevik 2014/11/05 09:48:37 You shouldn't do this. Pushing node to front-end i

samli 2014/11/10 23:59:31 I've updated as suggested to use a similar behavio

static String documentURLString(Document*);

@@ -232,7 +233,6 @@ private:

void inspect(Node*);

- int pushNodePathToFrontend(Node*);

void pushChildNodesToFrontend(int nodeId, int depth = 1);

void invalidateFrameOwnerElement(LocalFrame*);