Devtools Animations: Show subtree animations for a given node

Source/core/inspector/InspectorDOMAgent.h

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 169 matching lines @@
     void didInvalidateStyleAttr(Node*);
     void didPushShadowRoot(Element* host, ShadowRoot*);
     void willPopShadowRoot(Element* host, ShadowRoot*);
     void frameDocumentUpdated(LocalFrame*);
     void pseudoElementCreated(PseudoElement*);
     void pseudoElementDestroyed(PseudoElement*);
 
     Node* nodeForId(int nodeId);
     int boundNodeId(Node*);
     void setDOMListener(DOMListener*);
+    int pushNodePathToFrontend(Node*);

[vsevik, 2014/11/05 09:48:37]

You shouldn't do this.
Pushing node to front-end is expensive and we should only do this when
necessary. 
We have a special type of NodeId called BackendNodeId that is used for nodes
that were not pushed to front-end yet and you could use them here.

InspectorNodeIds::idForNode(node) allow you to get BackendNodeId.
DOM.pushNodesByBackendIdsToFrontend protocol method allows you to request
pushing of given nodes to front-end.

You could see LayerTreeModel.js / InspectorLayerTreeAgent for reference.

[samli, 2014/11/10 23:59:31]

I've updated as suggested to use a similar behavior of resolving the node from
the front-end.

 
     static String documentURLString(Document*);
 
     PassRefPtr<TypeBuilder::Runtime::RemoteObject> resolveNode(Node*, const String& objectGroup);
     bool handleMousePress();
     bool handleGestureEvent(LocalFrame*, const PlatformGestureEvent&);
     bool handleTouchEvent(LocalFrame*, const PlatformTouchEvent&);
     bool handleMouseMove(LocalFrame*, const PlatformMouseEvent&);
 
     InspectorHistory* history() { return m_history.get(); }
@@ skipping 25 matching lines @@
     typedef WillBeHeapHashMap<RefPtrWillBeMember<Node>, int> NodeToIdMap;
     int bind(Node*, NodeToIdMap*);
     void unbind(Node*, NodeToIdMap*);
 
     Node* assertEditableNode(ErrorString*, int nodeId);
     Node* assertEditableChildNode(ErrorString*, Element* parentElement, int nodeId);
     Element* assertEditableElement(ErrorString*, int nodeId);
 
     void inspect(Node*);
 
-    int pushNodePathToFrontend(Node*);
     void pushChildNodesToFrontend(int nodeId, int depth = 1);
 
     void invalidateFrameOwnerElement(LocalFrame*);
 
     PassRefPtr<TypeBuilder::DOM::Node> buildObjectForNode(Node*, int depth, NodeToIdMap*);
     PassRefPtr<TypeBuilder::Array<String> > buildArrayForElementAttributes(Element*);
     PassRefPtr<TypeBuilder::Array<TypeBuilder::DOM::Node> > buildArrayForContainerChildren(Node* container, int depth, NodeToIdMap* nodesMap);
     PassRefPtr<TypeBuilder::DOM::EventListener> buildObjectForEventListener(const RegisteredEventListener&, const AtomicString& eventType, Node*, const String* objectGroupId);
     PassRefPtr<TypeBuilder::Array<TypeBuilder::DOM::Node> > buildArrayForPseudoElements(Element*, NodeToIdMap* nodesMap);
 
@@ skipping 27 matching lines @@
     OwnPtrWillBeMember<InspectorHistory> m_history;
     OwnPtrWillBeMember<DOMEditor> m_domEditor;
     bool m_suppressAttributeModifiedEvent;
     RawPtrWillBeMember<Listener> m_listener;
 };
 
 
 } // namespace blink
 
 #endif // !defined(InspectorDOMAgent_h)