sky/viewer/document_view.h - Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/viewer/document_view.h

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/viewer/document_view.h

diff --git a/sky/viewer/document_view.h b/sky/viewer/document_view.h

index 88abb6a92503fc1756d10354214791b2d9cd9071..82489c748ede5726f5042727a79071607d6f6a59 100644

--- a/sky/viewer/document_view.h

+++ b/sky/viewer/document_view.h

@@ -69,7 +69,8 @@ class DocumentView : public mojo::InterfaceImpl<mojo::Application>,

virtual blink::WebLayerTreeView* initializeLayerTreeView();

// WebFrameClient methods:

- void createChildView(const blink::WebURL&) override;

+ uint32_t createChildFrame(const blink::WebURL& url) override;

+ void initializeChildFrame(uint32_t frame_id, const blink::WebRect& bounds) override;

void frameDetached(blink::WebFrame*) override;

blink::WebNavigationPolicy decidePolicyForNavigation(

const blink::WebFrameClient::NavigationPolicyInfo& info) override;

« sky/engine/web/FrameLoaderClientImpl.cpp ('K') | « sky/engine/web/FrameLoaderClientImpl.cpp ('k') | sky/viewer/document_view.cc » ('j') | sky/viewer/document_view.cc » ('J')