Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: sky/engine/web/FrameLoaderClientImpl.cpp

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/web/FrameLoaderClientImpl.cpp
diff --git a/sky/engine/web/FrameLoaderClientImpl.cpp b/sky/engine/web/FrameLoaderClientImpl.cpp
index 5c835c52b42ea77d4fc5a24b61b53c56ab12a4de..b1f1df0c53f0660a401e4535a007c9349e1b7f2f 100644
--- a/sky/engine/web/FrameLoaderClientImpl.cpp
+++ b/sky/engine/web/FrameLoaderClientImpl.cpp
@@ -251,10 +251,18 @@ void FrameLoaderClientImpl::loadURLExternally(const ResourceRequest& request, Na
}
}
-void FrameLoaderClientImpl::createView(const KURL& url)
+uint32_t FrameLoaderClientImpl::createChildFrame(const KURL& url)
{
if (m_webFrame->client()) {
- m_webFrame->client()->createChildView(url);
+ return m_webFrame->client()->createChildFrame(url);
+ }
+ return -1;
abarth-chromium 2014/11/07 21:25:50 We shouldn't ever get into this situation. Maybe
abarth-chromium 2014/11/07 21:25:50 We shouldn't ever get into this situation. Maybe
Matt Perry 2014/11/10 23:00:56 Done.
+}
+
+void FrameLoaderClientImpl::initializeChildFrame(uint32_t frame_id, const IntRect& bounds)
+{
+ if (m_webFrame->client()) {
+ return m_webFrame->client()->initializeChildFrame(frame_id, bounds);
}
}

Powered by Google App Engine
This is Rietveld 408576698