sky/engine/web/FrameLoaderClientImpl.h - Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/web/FrameLoaderClientImpl.h

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sky/engine/core/rendering/RenderRemote.cpp ('K') | « sky/engine/public/web/WebFrameClient.h ('k') | sky/engine/web/FrameLoaderClientImpl.cpp » ('j') | sky/engine/web/FrameLoaderClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/web/FrameLoaderClientImpl.h

diff --git a/sky/engine/web/FrameLoaderClientImpl.h b/sky/engine/web/FrameLoaderClientImpl.h

index 54582f6b7cc6dcbc13403ee701ba08796004d77b..0b1bdb9ec36b7d516e24f41f17252d69bc336301 100644

--- a/sky/engine/web/FrameLoaderClientImpl.h

+++ b/sky/engine/web/FrameLoaderClientImpl.h

@@ -73,7 +73,8 @@ public:

virtual void didStopLoading() override;

virtual void progressEstimateChanged(double progressEstimate) override;

virtual void loadURLExternally(const ResourceRequest&, NavigationPolicy, const String& suggestedName = String()) override;

- virtual void createView(const KURL&) override;

+ virtual uint32_t createChildFrame(const KURL&) override;

+ virtual void initializeChildFrame(uint32_t, const IntRect&) override;

virtual void selectorMatchChanged(const Vector<String>& addedSelectors, const Vector<String>& removedSelectors) override;

virtual void transitionToCommittedForNewPage() override;

virtual void didChangeScrollOffset() override;