sky/engine/core/loader/EmptyClients.h - Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/loader/EmptyClients.h

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sky/engine/core/html/HTMLIFrameElement.cpp ('k') | sky/engine/core/loader/FrameLoaderClient.h » ('j') | sky/engine/core/loader/FrameLoaderClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/loader/EmptyClients.h

diff --git a/sky/engine/core/loader/EmptyClients.h b/sky/engine/core/loader/EmptyClients.h

index e29586b314fcf0d65896e665da38060b93b0f0bb..6d7132fcd27160f819aada8ce1f16df6d301f9f1 100644

--- a/sky/engine/core/loader/EmptyClients.h

+++ b/sky/engine/core/loader/EmptyClients.h

@@ -130,7 +130,8 @@ public:

virtual void didStopLoading() override { }

virtual void loadURLExternally(const ResourceRequest&, NavigationPolicy, const String& = String()) override { }

- virtual void createView(const KURL&) override {}

+ virtual uint32_t createChildFrame(const KURL&) override { return static_cast<uint32_t>(-1); }

abarth-chromium 2014/11/07 21:25:50 -1 is a strange uint32_t. Maybe std::numeric_limi

Matt Perry 2014/11/10 23:00:56 view.cc initializes id_ to -1 when it's not define

+ virtual void initializeChildFrame(uint32_t, const IntRect&) override { }

virtual void transitionToCommittedForNewPage() override { }

« no previous file with comments | « sky/engine/core/html/HTMLIFrameElement.cpp ('k') | sky/engine/core/loader/FrameLoaderClient.h » ('j') | sky/engine/core/loader/FrameLoaderClient.h » ('J')