Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: sky/engine/core/loader/FrameLoaderClient.h

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/loader/FrameLoaderClient.h
diff --git a/sky/engine/core/loader/FrameLoaderClient.h b/sky/engine/core/loader/FrameLoaderClient.h
index ebce8059db8a786a1cb78f9b81fdf69745896bb3..1aba75551495597e03158c69e86374276dac3285 100644
--- a/sky/engine/core/loader/FrameLoaderClient.h
+++ b/sky/engine/core/loader/FrameLoaderClient.h
@@ -49,6 +49,7 @@ namespace blink {
class FetchRequest;
class FrameLoader;
class FrameNetworkingContext;
+ class IntRect;
class IntSize;
class KURL;
class LocalFrame;
@@ -88,7 +89,8 @@ namespace blink {
virtual void loadURLExternally(const ResourceRequest&, NavigationPolicy, const String& suggestedName = String()) = 0;
// TODO(mpcomplete): return surface ID?
- virtual void createView(const KURL&) = 0;
+ virtual uint32_t createChildFrame(const KURL&) = 0;
+ virtual void initializeChildFrame(uint32_t, const IntRect&) = 0;
abarth-chromium 2014/11/07 21:25:50 Seems like createChildFrame should return an objec
Matt Perry 2014/11/10 23:00:56 Done.
// Transmits the change in the set of watched CSS selectors property
// that match any element on the frame.

Powered by Google App Engine
This is Rietveld 408576698