Added code to support launch new tab with context menu

Added code to support launch new tab with context menu

Currently if context menu is invoked on any anchor link and
'open in new tab' option is selected then nothing happens.
Adding code to launch new tab with selected url

BUG=428625
Committed: https://crrev.com/954cd1187f48c862296f1e9fad66bc9b5ea347e6
Cr-Commit-Position: refs/heads/master@{#302252}

[ankit, 2014-10-30 10:43:53]

ankit2.kumar@samsung.com changed reviewers:
+ bauerb@chromium.org

[ankit, 2014-10-30 10:43:54]

PTAL

[Bernhard Bauer, 2014-10-30 13:41:34]

bauerb@chromium.org changed reviewers:
+ jdduke@chromium.org

[Bernhard Bauer, 2014-10-30 13:41:35]

https://codereview.chromium.org/682223003/diff/1/chrome/android/shell/java/sr...
File chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java
(right):

https://codereview.chromium.org/682223003/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java:79:
mTabModelSelector.setTabManager(this);
Any reason you're using a mutator here instead of passing it into the
constructor?

[ankit, 2014-10-30 14:16:46]

PTAL comment

https://codereview.chromium.org/682223003/diff/1/chrome/android/shell/java/sr...
File chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java
(right):

https://codereview.chromium.org/682223003/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java:79:
mTabModelSelector.setTabManager(this);
On 2014/10/30 13:41:35, Bernhard Bauer wrote:
> Any reason you're using a mutator here instead of passing it into the
> constructor?

I just thought if ChromeShellTabModelSelector is created by any other place in
future for testing purpose which does not require to maintan TabManager object
then it will be an addition task to do that. To avoid changing constructor I
have used mutator. 
Please suggest your opinion

[ankit, 2014-10-31 11:17:09]

On 2014/10/30 14:16:46, ankit wrote:
> PTAL comment
> 
>
https://codereview.chromium.org/682223003/diff/1/chrome/android/shell/java/sr...
> File chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java
> (right):
> 
>
https://codereview.chromium.org/682223003/diff/1/chrome/android/shell/java/sr...
> chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java:79:
> mTabModelSelector.setTabManager(this);
> On 2014/10/30 13:41:35, Bernhard Bauer wrote:
> > Any reason you're using a mutator here instead of passing it into the
> > constructor?
> 
> I just thought if ChromeShellTabModelSelector is created by any other place in
> future for testing purpose which does not require to maintan TabManager object
> then it will be an addition task to do that. To avoid changing constructor I
> have used mutator. 
> Please suggest your opinion

@Bernhard
PTAL

[Bernhard Bauer, 2014-10-31 11:22:36]

https://codereview.chromium.org/682223003/diff/1/chrome/android/shell/java/sr...
File chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java
(right):

https://codereview.chromium.org/682223003/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java:79:
mTabModelSelector.setTabManager(this);
On 2014/10/30 14:16:46, ankit wrote:
> On 2014/10/30 13:41:35, Bernhard Bauer wrote:
> > Any reason you're using a mutator here instead of passing it into the
> > constructor?
> 
> I just thought if ChromeShellTabModelSelector is created by any other place in
> future for testing purpose which does not require to maintan TabManager object
> then it will be an addition task to do that. To avoid changing constructor I
> have used mutator. 
> Please suggest your opinion 

Eh. I would rather allow ChromeShellTabModelSelector to assume that its
TabManager is always non-null (you might have noticed I don't like having silent
null-checks all over the place). If we want to use ChromeShellTabModelSelector
without a TabManager in the future, we can still refactor it then.

[ankit, 2014-10-31 11:41:46]

On 2014/10/31 11:22:36, Bernhard Bauer wrote:
>
https://codereview.chromium.org/682223003/diff/1/chrome/android/shell/java/sr...
> File chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java
> (right):
> 
>
https://codereview.chromium.org/682223003/diff/1/chrome/android/shell/java/sr...
> chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java:79:
> mTabModelSelector.setTabManager(this);
> On 2014/10/30 14:16:46, ankit wrote:
> > On 2014/10/30 13:41:35, Bernhard Bauer wrote:
> > > Any reason you're using a mutator here instead of passing it into the
> > > constructor?
> > 
> > I just thought if ChromeShellTabModelSelector is created by any other place
in
> > future for testing purpose which does not require to maintan TabManager
object
> > then it will be an addition task to do that. To avoid changing constructor I
> > have used mutator. 
> > Please suggest your opinion 
> 
> Eh. I would rather allow ChromeShellTabModelSelector to assume that its
> TabManager is always non-null 
(you might have noticed I don't like having silent
> null-checks all over the place). 
I have definitely noticed this point.

>If we want to use ChromeShellTabModelSelector
> without a TabManager in the future, we can still refactor it then.
Sure. No problem.

@Bernhard
PTAL new patch set.

[Bernhard Bauer, 2014-10-31 11:50:29]

lgtm

[ankit, 2014-10-31 12:12:15]

On 2014/10/31 11:50:29, Bernhard Bauer wrote:
> lgtm

Thanks.

[ankit, 2014-10-31 12:12:21]

The CQ bit was checked by ankit2.kumar@samsung.com

[commit-bot: I haz the power, 2014-10-31 12:13:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682223003/20001

[commit-bot: I haz the power, 2014-10-31 12:52:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-31 12:53:17]

Patchset 2 (id:??) landed as
https://crrev.com/954cd1187f48c862296f1e9fad66bc9b5ea347e6
Cr-Commit-Position: refs/heads/master@{#302252}