Added code to support launch new tab with context menu

chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.shell;
 
 import android.content.Context;
 import android.util.AttributeSet;
 import android.view.View;
 import android.view.ViewGroup;
@@ skipping 58 matching lines @@
      * @param videoViewClient The client to handle interactions from ContentVideoViews.
      */
     public void initialize(WindowAndroid window, ContentVideoViewClient videoViewClient) {
         assert window != null;
         assert videoViewClient != null;
 
         mContentViewHolder = (ViewGroup) findViewById(R.id.content_container);
 
         mTabModelSelector = new ChromeShellTabModelSelector(
                 window, videoViewClient, mContentViewHolder);
+        mTabModelSelector.setTabManager(this);

[Bernhard Bauer, 2014/10/30 13:41:35]

Any reason you're using a mutator here instead of passing it into the
constructor?

[ankit, 2014/10/30 14:16:46]

I just thought if ChromeShellTabModelSelector is created by any other place in
future for testing purpose which does not require to maintan TabManager object
then it will be an addition task to do that. To avoid changing constructor I
have used mutator. 
Please suggest your opinion 

[Bernhard Bauer, 2014/10/31 11:22:36]

Eh. I would rather allow ChromeShellTabModelSelector to assume that its
TabManager is always non-null (you might have noticed I don't like having silent
null-checks all over the place). If we want to use ChromeShellTabModelSelector
without a TabManager in the future, we can still refactor it then.

         mTabModelSelector.getModel(false).addObserver(mTabModelObserver);
 
         mToolbar = (ChromeShellToolbar) findViewById(R.id.toolbar);
         mToolbar.setTabManager(this);
         mContentViewRenderView = new ContentViewRenderView(getContext()) {
             @Override
             protected void onReadyToRender() {
                 if (mCurrentTab == null) createTab(mStartupUrl, TabLaunchType.FROM_RESTORE);
             }
         };
@@ skipping 110 matching lines @@
         LoadUrlParams loadUrlParams = new LoadUrlParams(url);
         loadUrlParams.setTransitionType(PageTransition.TYPED | PageTransition.FROM_ADDRESS_BAR);
         Tab tab = mTabModelSelector.getCurrentTab();
         if (tab != null) {
             tab.loadUrl(loadUrlParams);
             return tab;
         }
         return createTab(url, TabLaunchType.FROM_KEYBOARD);
     }
 }