Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 681983005: Basic implementation of <import> (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn, ojan
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Basic implementation of <import> This CL adds basic support for the <import> elements. We're using the same imports machinery as <link rel="import">, which simplifies this patch substantially. Currently we support both <link rel="import"> and <import>. Once this CL lands, I'll update all the existing modules and then we can drop support for <link rel="import">. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5df5a843267155b02650ff981f76324541d35681

Patch Set 1 #

Patch Set 2 : Works #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -20 lines) Patch
M sky/engine/bindings/core/v8/ScriptController.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/core.gni View 1 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/dom/Document.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M sky/engine/core/fetch/FetchRequest.h View 1 chunk +1 line, -1 line 0 comments Download
A sky/engine/core/html/HTMLImportElement.h View 1 chunk +39 lines, -0 lines 0 comments Download
A sky/engine/core/html/HTMLImportElement.cpp View 1 1 chunk +75 lines, -0 lines 2 comments Download
A + sky/engine/core/html/HTMLImportElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLTagNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportChild.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportChild.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/imports/HTMLImportChildClient.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/html/imports/LinkImport.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/imports/LinkImport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/modules/basic.sky View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/modules/import-without-export.sky View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/modules/imports-can-import.sky View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/modules/imports-can-load-404s.sky View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/modules/resources/intermediate.sky View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-11-03 04:48:14 UTC) #2
ojan
lgtm https://codereview.chromium.org/681983005/diff/20001/sky/engine/core/html/HTMLImportElement.cpp File sky/engine/core/html/HTMLImportElement.cpp (right): https://codereview.chromium.org/681983005/diff/20001/sky/engine/core/html/HTMLImportElement.cpp#newcode8 sky/engine/core/html/HTMLImportElement.cpp:8: #include "base/debug/stack_trace.h" leftover?
6 years, 1 month ago (2014-11-03 18:08:29 UTC) #3
abarth-chromium
Committed patchset #2 (id:20001) manually as 5df5a843267155b02650ff981f76324541d35681.
6 years, 1 month ago (2014-11-03 18:14:13 UTC) #4
abarth-chromium
6 years, 1 month ago (2014-11-03 20:37:02 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/681983005/diff/20001/sky/engine/core/html/HTM...
File sky/engine/core/html/HTMLImportElement.cpp (right):

https://codereview.chromium.org/681983005/diff/20001/sky/engine/core/html/HTM...
sky/engine/core/html/HTMLImportElement.cpp:8: #include
"base/debug/stack_trace.h"
On 2014/11/03 at 18:08:29, ojan wrote:
> leftover?

Fixed!

Powered by Google App Engine
This is Rietveld 408576698