Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: sky/engine/bindings/core/v8/ScriptController.cpp

Issue 681983005: Basic implementation of <import> (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Works Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/core.gni » ('j') | sky/engine/core/html/HTMLImportElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/ScriptController.cpp
diff --git a/sky/engine/bindings/core/v8/ScriptController.cpp b/sky/engine/bindings/core/v8/ScriptController.cpp
index af3e490d95abd4d6608a63dbdd9a5b2cf992b27a..db558ee2bc6c1c37b9701fabdbc9a27c0cf93f85 100644
--- a/sky/engine/bindings/core/v8/ScriptController.cpp
+++ b/sky/engine/bindings/core/v8/ScriptController.cpp
@@ -353,8 +353,8 @@ void ScriptController::executeModuleScript(Document& document, const String& sou
if (HTMLImport* parent = document.import()) {
for (HTMLImport* child = parent->firstChild(); child; child = child->next()) {
- if (HTMLLinkElement* link = static_cast<HTMLImportChild*>(child)->link()) {
- String name = link->as();
+ if (Element* link = static_cast<HTMLImportChild*>(child)->link()) {
+ String name = link->getAttribute(HTMLNames::asAttr);
if (!name.isEmpty()) {
module.formalDependencies.append(name);
v8::Handle<v8::Value> actual;
« no previous file with comments | « no previous file | sky/engine/core/core.gni » ('j') | sky/engine/core/html/HTMLImportElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698