Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: content/browser/mach_broker_mac_unittest.cc

Issue 681733003: Removed the ProcessHandle from the RendererClosedDetails payload (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed mac issues Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/mach_broker_mac_unittest.cc
diff --git a/content/browser/mach_broker_mac_unittest.cc b/content/browser/mach_broker_mac_unittest.cc
index a7eca4fd2f4ff770d181bfec2598d224d42dc7af..1b28f67dac2c5f6e7ff83a682059636694038028 100644
--- a/content/browser/mach_broker_mac_unittest.cc
+++ b/content/browser/mach_broker_mac_unittest.cc
@@ -12,9 +12,9 @@ namespace content {
class MachBrokerTest : public testing::Test {
public:
// Helper function to acquire/release locks and call |PlaceholderForPid()|.
- void AddPlaceholderForPid(base::ProcessHandle pid) {
+ void AddPlaceholderForPid(base::ProcessHandle pid, int child_process_id) {
base::AutoLock lock(broker_.GetLock());
- broker_.AddPlaceholderForPid(pid);
+ broker_.AddPlaceholderForPid(pid, child_process_id);
}
void InvalidatePid(base::ProcessHandle pid) {
@@ -39,7 +39,7 @@ TEST_F(MachBrokerTest, Locks) {
TEST_F(MachBrokerTest, AddPlaceholderAndFinalize) {
// Add a placeholder for PID 1.
- AddPlaceholderForPid(1);
+ AddPlaceholderForPid(1, 1);
EXPECT_EQ(0u, broker_.TaskForPid(1));
// Finalize PID 1.
@@ -51,7 +51,7 @@ TEST_F(MachBrokerTest, AddPlaceholderAndFinalize) {
}
TEST_F(MachBrokerTest, Invalidate) {
- AddPlaceholderForPid(1);
+ AddPlaceholderForPid(1, 1);
Charlie Reis 2014/11/10 19:57:25 Please add tests for the new behavior you're addin
sramajay 2014/11/11 14:16:05 Done.
FinalizePid(1, 100u);
EXPECT_EQ(100u, broker_.TaskForPid(1));

Powered by Google App Engine
This is Rietveld 408576698