Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "content/browser/mach_broker_mac.h" | 5 #include "content/browser/mach_broker_mac.h" |
| 6 | 6 |
| 7 #include "base/synchronization/lock.h" | 7 #include "base/synchronization/lock.h" |
| 8 #include "testing/gtest/include/gtest/gtest.h" | 8 #include "testing/gtest/include/gtest/gtest.h" |
| 9 | 9 |
| 10 namespace content { | 10 namespace content { |
| 11 | 11 |
| 12 class MachBrokerTest : public testing::Test { | 12 class MachBrokerTest : public testing::Test { |
| 13 public: | 13 public: |
| 14 // Helper function to acquire/release locks and call |PlaceholderForPid()|. | 14 // Helper function to acquire/release locks and call |PlaceholderForPid()|. |
| 15 void AddPlaceholderForPid(base::ProcessHandle pid) { | 15 void AddPlaceholderForPid(base::ProcessHandle pid, int child_process_id) { |
| 16 base::AutoLock lock(broker_.GetLock()); | 16 base::AutoLock lock(broker_.GetLock()); |
| 17 broker_.AddPlaceholderForPid(pid); | 17 broker_.AddPlaceholderForPid(pid, child_process_id); |
| 18 } | 18 } |
| 19 | 19 |
| 20 void InvalidatePid(base::ProcessHandle pid) { | 20 void InvalidatePid(base::ProcessHandle pid) { |
| 21 broker_.InvalidatePid(pid); | 21 broker_.InvalidatePid(pid); |
| 22 } | 22 } |
| 23 | 23 |
| 24 // Helper function to acquire/release locks and call |FinalizePid()|. | 24 // Helper function to acquire/release locks and call |FinalizePid()|. |
| 25 void FinalizePid(base::ProcessHandle pid, | 25 void FinalizePid(base::ProcessHandle pid, |
| 26 mach_port_t task_port) { | 26 mach_port_t task_port) { |
| 27 base::AutoLock lock(broker_.GetLock()); | 27 base::AutoLock lock(broker_.GetLock()); |
| 28 broker_.FinalizePid(pid, task_port); | 28 broker_.FinalizePid(pid, task_port); |
| 29 } | 29 } |
| 30 | 30 |
| 31 protected: | 31 protected: |
| 32 MachBroker broker_; | 32 MachBroker broker_; |
| 33 }; | 33 }; |
| 34 | 34 |
| 35 TEST_F(MachBrokerTest, Locks) { | 35 TEST_F(MachBrokerTest, Locks) { |
| 36 // Acquire and release the locks. Nothing bad should happen. | 36 // Acquire and release the locks. Nothing bad should happen. |
| 37 base::AutoLock lock(broker_.GetLock()); | 37 base::AutoLock lock(broker_.GetLock()); |
| 38 } | 38 } |
| 39 | 39 |
| 40 TEST_F(MachBrokerTest, AddPlaceholderAndFinalize) { | 40 TEST_F(MachBrokerTest, AddPlaceholderAndFinalize) { |
| 41 // Add a placeholder for PID 1. | 41 // Add a placeholder for PID 1. |
| 42 AddPlaceholderForPid(1); | 42 AddPlaceholderForPid(1, 1); |
| 43 EXPECT_EQ(0u, broker_.TaskForPid(1)); | 43 EXPECT_EQ(0u, broker_.TaskForPid(1)); |
| 44 | 44 |
| 45 // Finalize PID 1. | 45 // Finalize PID 1. |
| 46 FinalizePid(1, 100u); | 46 FinalizePid(1, 100u); |
| 47 EXPECT_EQ(100u, broker_.TaskForPid(1)); | 47 EXPECT_EQ(100u, broker_.TaskForPid(1)); |
| 48 | 48 |
| 49 // Should be no entry for PID 2. | 49 // Should be no entry for PID 2. |
| 50 EXPECT_EQ(0u, broker_.TaskForPid(2)); | 50 EXPECT_EQ(0u, broker_.TaskForPid(2)); |
| 51 } | 51 } |
| 52 | 52 |
| 53 TEST_F(MachBrokerTest, Invalidate) { | 53 TEST_F(MachBrokerTest, Invalidate) { |
| 54 AddPlaceholderForPid(1); | 54 AddPlaceholderForPid(1, 1); |
|
Charlie Reis
2014/11/10 19:57:25
Please add tests for the new behavior you're addin
sramajay
2014/11/11 14:16:05
Done.
| |
| 55 FinalizePid(1, 100u); | 55 FinalizePid(1, 100u); |
| 56 | 56 |
| 57 EXPECT_EQ(100u, broker_.TaskForPid(1)); | 57 EXPECT_EQ(100u, broker_.TaskForPid(1)); |
| 58 InvalidatePid(1u); | 58 InvalidatePid(1u); |
| 59 EXPECT_EQ(0u, broker_.TaskForPid(1)); | 59 EXPECT_EQ(0u, broker_.TaskForPid(1)); |
| 60 } | 60 } |
| 61 | 61 |
| 62 TEST_F(MachBrokerTest, FinalizeUnknownPid) { | 62 TEST_F(MachBrokerTest, FinalizeUnknownPid) { |
| 63 // Finalizing an entry for an unknown pid should not add it to the map. | 63 // Finalizing an entry for an unknown pid should not add it to the map. |
| 64 FinalizePid(1u, 100u); | 64 FinalizePid(1u, 100u); |
| 65 EXPECT_EQ(0u, broker_.TaskForPid(1u)); | 65 EXPECT_EQ(0u, broker_.TaskForPid(1u)); |
| 66 } | 66 } |
| 67 | 67 |
| 68 } // namespace content | 68 } // namespace content |
| OLD | NEW |