Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromeos/dbus/shill_service_client_unittest.cc

Issue 681723003: Add new shill client for VPN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chromeos/dbus/shill_manager_client_unittest.cc ('K') | « chromeos/dbus/shill_manager_client_unittest.cc ('k') | chromeos/dbus/shill_third_party_vpn_driver_client.h » ('j') | chromeos/dbus/shill_third_party_vpn_driver_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_service_client_unittest.cc
diff --git a/chromeos/dbus/shill_service_client_unittest.cc b/chromeos/dbus/shill_service_client_unittest.cc
index 3f1df25788bc1a1ccd7cf9ead351e40f8c06c412..67740de9fac6ae7e55f8826ffd80b37db741d2bf 100644
--- a/chromeos/dbus/shill_service_client_unittest.cc
+++ b/chromeos/dbus/shill_service_client_unittest.cc
@@ -144,9 +144,10 @@ TEST_F(ShillServiceClientTest, SetProperties) {
// Set expectations.
scoped_ptr<base::DictionaryValue> arg(CreateExampleServiceProperties());
- PrepareForMethodCall(shill::kSetPropertiesFunction,
- base::Bind(&ExpectDictionaryValueArgument, arg.get()),
- response.get());
+ PrepareForMethodCall(
+ shill::kSetPropertiesFunction,
+ base::Bind(&ExpectDictionaryValueArgument, arg.get(), false),
stevenjb 2014/10/31 16:35:41 comment false
kaliamoorthi 2014/11/03 10:55:38 Done.
+ response.get());
// Call method.
MockClosure mock_closure;
« chromeos/dbus/shill_manager_client_unittest.cc ('K') | « chromeos/dbus/shill_manager_client_unittest.cc ('k') | chromeos/dbus/shill_third_party_vpn_driver_client.h » ('j') | chromeos/dbus/shill_third_party_vpn_driver_client.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698