Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chromeos/dbus/shill_manager_client_unittest.cc

Issue 681723003: Add new shill client for VPN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_manager_client_unittest.cc
diff --git a/chromeos/dbus/shill_manager_client_unittest.cc b/chromeos/dbus/shill_manager_client_unittest.cc
index a5c6c7a3b320a4aa841b1a3e5b19354758c739f9..72a62b6221a53794ceedc1ae5ada6fe512a8b57f 100644
--- a/chromeos/dbus/shill_manager_client_unittest.cc
+++ b/chromeos/dbus/shill_manager_client_unittest.cc
@@ -274,9 +274,10 @@ TEST_F(ShillManagerClientTest, ConfigureService) {
// Create the argument dictionary.
scoped_ptr<base::DictionaryValue> arg(CreateExampleServiceProperties());
// Set expectations.
- PrepareForMethodCall(shill::kConfigureServiceFunction,
- base::Bind(&ExpectDictionaryValueArgument, arg.get()),
- response.get());
+ PrepareForMethodCall(
+ shill::kConfigureServiceFunction,
+ base::Bind(&ExpectDictionaryValueArgument, arg.get(), false),
stevenjb 2014/10/31 16:35:41 comment 'false' here and elsewhere
kaliamoorthi 2014/11/03 10:55:38 Done.
+ response.get());
// Call method.
MockErrorCallback mock_error_callback;
client_->ConfigureService(*arg,
@@ -298,9 +299,10 @@ TEST_F(ShillManagerClientTest, GetService) {
// Create the argument dictionary.
scoped_ptr<base::DictionaryValue> arg(CreateExampleServiceProperties());
// Set expectations.
- PrepareForMethodCall(shill::kGetServiceFunction,
- base::Bind(&ExpectDictionaryValueArgument, arg.get()),
- response.get());
+ PrepareForMethodCall(
+ shill::kGetServiceFunction,
+ base::Bind(&ExpectDictionaryValueArgument, arg.get(), false),
+ response.get());
// Call method.
MockErrorCallback mock_error_callback;
client_->GetService(*arg,

Powered by Google App Engine
This is Rietveld 408576698