Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 68163013: Properly substitute variables that reference paths outside SRCDIR. (Closed)

Created:
7 years, 1 month ago by Jói
Modified:
7 years, 1 month ago
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Properly substitute variables that reference paths outside SRCDIR. Apply the same kind of trick added in r58 and use a define's base name if it refers to a location outside SRCDIR; so far, GritNode::AssignFirstIds() would parse a file name differently than _ReadFirstIdsFromFile() even though they refer to the same entry. TEST=in Chromium, make BUILDTYPE=Release builddir_name=/outside/srcdir/out tracing_resources R=joi@chromium.org Landing for original author raphael.kubo.da.costa@intel.com, https://codereview.chromium.org/69463002/ Committed: https://code.google.com/p/grit-i18n/source/detail?r=138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M grit/node/misc.py View 2 chunks +6 lines, -2 lines 0 comments Download
M grit/node/misc_unittest.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jói
Hi Raphael, FYI. Cheers, Jói
7 years, 1 month ago (2013-11-12 13:48:34 UTC) #1
Jói
7 years, 1 month ago (2013-11-12 13:48:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r138 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698