Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 681583002: Remove pinch viewports. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove pinch viewports. Sky doesn't have concept of pinch zoom. Remove more frame-level scrolling machinery. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/681cc3e1bd8215caee11889c19fbc9647b90c20c

Patch Set 1 #

Patch Set 2 : upload synced patch #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -842 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/ViewportDescription.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/frame/FrameHost.h View 4 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/frame/FrameHost.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 4 chunks +2 lines, -69 lines 2 comments Download
D sky/engine/core/frame/PinchViewport.h View 1 chunk +0 lines, -165 lines 0 comments Download
D sky/engine/core/frame/PinchViewport.cpp View 1 1 chunk +0 lines, -432 lines 0 comments Download
M sky/engine/core/frame/Settings.in View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/web/WebSettings.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/public/web/WebView.h View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/public/web/WebWidget.h View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/web/WebInputEventConversion.cpp View 6 chunks +3 lines, -20 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 1 1 chunk +1 line, -7 lines 0 comments Download
M sky/engine/web/WebSettingsImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 3 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 9 chunks +9 lines, -88 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
6 years, 1 month ago (2014-10-25 07:30:41 UTC) #1
esprehn
lgtm https://codereview.chromium.org/681583002/diff/20001/sky/engine/core/frame/FrameView.cpp File sky/engine/core/frame/FrameView.cpp (right): https://codereview.chromium.org/681583002/diff/20001/sky/engine/core/frame/FrameView.cpp#newcode758 sky/engine/core/frame/FrameView.cpp:758: // FIXME(sky): Remove This is okay to remove ...
6 years, 1 month ago (2014-10-25 07:33:27 UTC) #3
ojan
https://codereview.chromium.org/681583002/diff/20001/sky/engine/core/frame/FrameView.cpp File sky/engine/core/frame/FrameView.cpp (right): https://codereview.chromium.org/681583002/diff/20001/sky/engine/core/frame/FrameView.cpp#newcode758 sky/engine/core/frame/FrameView.cpp:758: // FIXME(sky): Remove On 2014/10/25 07:33:27, esprehn wrote: > ...
6 years, 1 month ago (2014-10-25 17:11:06 UTC) #4
ojan
6 years, 1 month ago (2014-10-25 17:11:27 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
681cc3e1bd8215caee11889c19fbc9647b90c20c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698