Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: sky/engine/web/WebLocalFrameImpl.cpp

Issue 681583002: Remove pinch viewports. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: upload synced patch Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/web/WebLocalFrameImpl.cpp
diff --git a/sky/engine/web/WebLocalFrameImpl.cpp b/sky/engine/web/WebLocalFrameImpl.cpp
index a2dc88e60db6ce8e43550f94d229113e38db967e..1faa8dbb75845a876f48b5fbf224b5d13b6a5b47 100644
--- a/sky/engine/web/WebLocalFrameImpl.cpp
+++ b/sky/engine/web/WebLocalFrameImpl.cpp
@@ -667,14 +667,8 @@ void WebLocalFrameImpl::setCaretVisible(bool visible)
VisiblePosition WebLocalFrameImpl::visiblePositionForWindowPoint(const WebPoint& point)
{
- // FIXME(bokan): crbug.com/371902 - These scale/pinch transforms shouldn't
- // be ad hoc and explicit.
- PinchViewport& pinchViewport = frame()->page()->frameHost().pinchViewport();
- FloatPoint unscaledPoint(point);
- unscaledPoint.moveBy(pinchViewport.visibleRect().location());
-
HitTestRequest request = HitTestRequest::Move | HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::IgnoreClipping;
- HitTestResult result(frame()->view()->windowToContents(roundedIntPoint(unscaledPoint)));
+ HitTestResult result(frame()->view()->windowToContents(roundedIntPoint(FloatPoint(point))));
frame()->document()->renderView()->layer()->hitTest(request, result);
if (Node* node = result.targetNode())

Powered by Google App Engine
This is Rietveld 408576698