Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 6815021: [login_manager] Code to add the owner to the whitelist in a device policy (Closed)

Created:
9 years, 8 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
gauravsh
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

[login_manager] Code to add the owner to the whitelist in a device policy Today, every time the owner logs in, we ensure he is on the whitelist and that we have him recorded in the signed settings store as the owner. Add code that can do the same thing for a device policy. BUG=13842 TEST=unit tests. Change-Id: I0073c7b0216879fb021f2319906ffd51bd54233f Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ac98340

Patch Set 1 #

Total comments: 37

Patch Set 2 : address gauravsh comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -136 lines) Patch
M Makefile View 1 1 chunk +6 lines, -3 lines 0 comments Download
M device_policy.h View 1 3 chunks +17 lines, -1 line 0 comments Download
M device_policy.cc View 1 4 chunks +73 lines, -2 lines 0 comments Download
M device_policy_unittest.cc View 1 5 chunks +111 lines, -4 lines 0 comments Download
M mock_device_policy.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mock_owner_key.h View 1 chunk +2 lines, -2 lines 0 comments Download
M owner_key.h View 1 chunk +2 lines, -2 lines 0 comments Download
M owner_key.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M session_manager_service.h View 2 chunks +2 lines, -12 lines 0 comments Download
M session_manager_service.cc View 23 chunks +47 lines, -64 lines 0 comments Download
M session_manager_unittest.cc View 1 10 chunks +36 lines, -42 lines 0 comments Download
M system_utils.h View 2 chunks +14 lines, -0 lines 0 comments Download
M system_utils.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Masone
this CL isn't as big as it looks.
9 years, 8 months ago (2011-04-08 00:05:53 UTC) #1
gauravsh
http://codereview.chromium.org/6815021/diff/1/Makefile File Makefile (right): http://codereview.chromium.org/6815021/diff/1/Makefile#newcode26 Makefile:26: $(PROTO_PATH)/chrome_device_policy.proto nit: put these in alpha order? same for ...
9 years, 8 months ago (2011-04-08 04:58:49 UTC) #2
Chris Masone
http://codereview.chromium.org/6815021/diff/1/Makefile File Makefile (right): http://codereview.chromium.org/6815021/diff/1/Makefile#newcode26 Makefile:26: $(PROTO_PATH)/chrome_device_policy.proto On 2011/04/08 04:58:49, gauravsh wrote: > nit: put ...
9 years, 8 months ago (2011-04-08 05:57:41 UTC) #3
gauravsh
9 years, 8 months ago (2011-04-08 18:07:47 UTC) #4
LGTM

http://codereview.chromium.org/6815021/diff/1/device_policy.h
File device_policy.h (right):

http://codereview.chromium.org/6815021/diff/1/device_policy.h#newcode41
device_policy.h:41: virtual bool SerializeToString(std::string* output) const;
On 2011/04/08 05:57:41, Chris Masone wrote:
> On 2011/04/08 04:58:49, gauravsh wrote:
> > what does this do?
> 
> Serializes the policy into the passed-in string object.  Kinda felt the same
as
> above.

Yeah, reading the full class definition provides the proper context.

Powered by Google App Engine
This is Rietveld 408576698