Issue 681333002: Add Geometry processor to srcAlphaWillBeOne check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 681333002: Add Geometry processor to srcAlphaWillBeOne check. (Closed)

Created:
6 years, 1 month ago by egdaniel

Modified:
6 years, 1 month ago

Reviewers:
bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/gpu/GrDrawState.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

egdaniel

As far as I can tell the gp should have been checked when running through ...

6 years, 1 month ago (2014-10-28 13:46:50 UTC) #2

bsalomon

On 2014/10/28 13:54:22, bsalomon wrote: > Definitely should be done lgtm

6 years, 1 month ago (2014-10-28 13:54:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681333002/1

6 years, 1 month ago (2014-10-28 13:58:07 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-10-28 14:06:40 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as a703b841e301adc7b39a3c1d936166c1286d8131