Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 681193002: Fix typos in device/bluetooth headers. (Closed)

Created:
6 years, 1 month ago by Ben Chan
Modified:
6 years, 1 month ago
Reviewers:
armansito
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix typos in device/bluetooth headers. BUG=None Committed: https://crrev.com/139a35b4ddbbd6a7f412f49658e8818aff909b2e Cr-Commit-Position: refs/heads/master@{#301576}

Patch Set 1 #

Total comments: 6

Patch Set 2 : more typo fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M device/bluetooth/bluetooth_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_characteristic.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_descriptor.h View 4 chunks +5 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_notify_session.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_service.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_init_win.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_low_energy_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_pairing_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ben Chan
6 years, 1 month ago (2014-10-28 05:02:14 UTC) #2
armansito
lol thanks. lgtm with a few nits with more typos for you to fix. https://codereview.chromium.org/681193002/diff/1/device/bluetooth/bluetooth_gatt_service.h ...
6 years, 1 month ago (2014-10-28 05:28:28 UTC) #3
Ben Chan
https://codereview.chromium.org/681193002/diff/1/device/bluetooth/bluetooth_gatt_service.h File device/bluetooth/bluetooth_gatt_service.h (right): https://codereview.chromium.org/681193002/diff/1/device/bluetooth/bluetooth_gatt_service.h#newcode68 device/bluetooth/bluetooth_gatt_service.h:68: // writeable and any authentication and authorization challenges were ...
6 years, 1 month ago (2014-10-28 05:33:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681193002/20001
6 years, 1 month ago (2014-10-28 05:36:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-28 06:32:29 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 06:33:18 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/139a35b4ddbbd6a7f412f49658e8818aff909b2e
Cr-Commit-Position: refs/heads/master@{#301576}

Powered by Google App Engine
This is Rietveld 408576698