Issue 681133004: [turbofan] Complete support for integer division/modulus in simplified lowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 681133004: [turbofan] Complete support for integer division/modulus in simplified lowering. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Complete support for integer division/modulus in simplified lowering. Also add backend flags that tell whether integer division/modulus is generally safe, i.e. does not trap on overflow or divide by zero. TEST=unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24942

Patch Set 1 #

Patch Set 2 : Fixes #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+276 lines, -146 lines)			Patch
M	src/compiler/arm/instruction-selector-arm.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/compiler/arm64/instruction-selector-arm64.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler/ia32/instruction-selector-ia32.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler/machine-operator.h	View		3 chunks	+19 lines, -15 lines	0 comments	Download
M	src/compiler/machine-operator-reducer.cc	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	src/compiler/node-matchers.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/operator-properties-inl.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/compiler/simplified-lowering.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/compiler/simplified-lowering.cc	View	1	3 chunks	+164 lines, -27 lines	0 comments	Download
M	src/compiler/x64/instruction-selector-x64.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/compiler/test-simplified-lowering.cc	View	1	6 chunks	+31 lines, -62 lines	0 comments	Download
M	test/unittests/compiler/machine-operator-unittest.cc	View		3 chunks	+39 lines, -38 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 1 month ago (2014-10-28 13:56:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24942 (presubmit successful).

Expand Messages | Collapse Messages