Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 681113009: Revert of Telemetry, Mac: Use the actual keychain for performance tests. (Closed)

Created:
6 years, 1 month ago by erikchen
Modified:
6 years, 1 month ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Telemetry, Mac: Use the actual keychain for performance tests. (patchset #1 id:1 of https://codereview.chromium.org/419133002/) Reason for revert: Bots need to have their configs updated before this CL can land. Original issue's description: > Telemetry, Mac: Use the actual keychain for performance tests. > > The real keychain was stubbed out because it was causing problems > with page cyclers on 10.9 perf bots. > https://codereview.chromium.org/176583002 > > This is problematic because it prevents us from catching real performance > regressions involving the keychain. > https://code.google.com/p/chromium/issues/detail?id=397308 > > Rather than disabling keychain interactions altogether, we should fix the 10.9 > page cycler problems. I added a wiki page describing the correct configuration > for the keychain on Macs. > https://sites.google.com/a/chromium.org/dev/developers/telemetry/telemetry-mac-keychain-setup > > This change will cause a serious performance regression for the telemetry test > session_restore, and possibly others, since Chrome does not interact well with > the keychain. See the associated bug. Note that this regression reflects > accurate user conditions, and that the current performance statistics are > artifically lowered by stubbing out keychain interactions. > > BUG=397308 > > Committed: https://crrev.com/e38f0dad2e9bdccfaa900e9c2bda2a6e61d85c8b > Cr-Commit-Position: refs/heads/master@{#302917} TBR=tonyg@chromium.org,oysteine@chromium.org,jeremy@chromium.org NOTREECHECKS=true NOTRY=true BUG=397308 Committed: https://crrev.com/ba614dbec9638745a84f13bd15215d4fab00bf9d Cr-Commit-Position: refs/heads/master@{#303057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of Telemetry, Mac: Use the actual keychain for performance tests.
6 years, 1 month ago (2014-11-06 18:55:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681113009/1
6 years, 1 month ago (2014-11-06 18:57:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-06 18:58:24 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 18:59:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba614dbec9638745a84f13bd15215d4fab00bf9d
Cr-Commit-Position: refs/heads/master@{#303057}

Powered by Google App Engine
This is Rietveld 408576698