Issue 176583002: [OS X] Wire up --use-mock-keychain command line flag to encryptor module

Issue 176583002: [OS X] Wire up --use-mock-keychain command line flag to encryptor module (Closed)

Created:
6 years, 10 months ago by jeremy

Modified:
6 years, 10 months ago

Reviewers:
tonyg, jochen (gone - plz use gerrit), Jói, marja

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, tonyg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[OS X] Wire up --use-mock-keychain command line flag to encryptor module Respect --use-mock-keychain command line flag in encryptor module, also pass this flag when running Chrome via Telemetry. BUG=344318, 339149 R=jochen@chromium.org, joi@chromium.org, marja@chromium.org, tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253162

Patch Set 2 : Whitespace fixes #

Patch Set 5 : Fix license header #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -7 lines)			Patch
M	chrome/browser/password_manager/password_store_factory.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2 3 4	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/test/base/test_launcher_utils.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	components/encryptor.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/encryptor/encryptor_mac.mm	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download
A	components/encryptor/encryptor_switches.h	View	1 2 3 4	1 chunk	+26 lines, -0 lines	0 comments	Download
A	components/encryptor/encryptor_switches.cc	View	1 2 3 4	1 chunk	+17 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

jeremy

Joi: review please, thanks again for your guidance with this! jochen: owner review, rubberstamp ok. ...

6 years, 10 months ago (2014-02-23 13:38:50 UTC) #1

Jói

LGTM https://codereview.chromium.org/176583002/diff/70001/components/encryptor/encryptor_switches.h File components/encryptor/encryptor_switches.h (right): https://codereview.chromium.org/176583002/diff/70001/components/encryptor/encryptor_switches.h#newcode1 components/encryptor/encryptor_switches.h:1: // Copyright (c) 2014 The Chromium Authors. All ...

6 years, 10 months ago (2014-02-24 12:50:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/176583002/290001

6 years, 10 months ago (2014-02-25 09:49:42 UTC) #7

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 10 months ago (2014-02-25 13:18:00 UTC) #8

commit-bot: I haz the power

Try jobs failed on following builders: mac_chromium_rel

6 years, 10 months ago (2014-02-25 13:18:00 UTC) #9

jeremy

6 years, 10 months ago (2014-02-25 15:11:36 UTC) #10

Message was sent while issue was closed.

Committed patchset #5 manually as r253162 (presubmit successful).

Expand Messages | Collapse Messages