Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 681113006: Remove keyboard event filtering in fullscreen (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
pdr.
CC:
blink-reviews, arv+blink, blink-reviews-events_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -109 lines) Patch
D LayoutTests/fullscreen/full-screen-keyboard-disabled.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-keyboard-disabled-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/dom/DocumentFullscreen.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DocumentFullscreen.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/dom/DocumentFullscreen.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ElementFullscreen.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/ElementFullscreen.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/dom/ElementFullscreen.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/Fullscreen.h View 3 chunks +1 line, -5 lines 0 comments Download
M Source/core/dom/Fullscreen.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 2 chunks +0 lines, -28 lines 0 comments Download
M Source/web/WebElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
philipj_slow
oops
6 years, 1 month ago (2014-10-29 14:45:19 UTC) #1
philipj_slow
PTAL. The blink-dev thread doesn't have a clear conclusion, I'm hoping to skip the deprecation ...
6 years, 1 month ago (2014-10-30 14:40:54 UTC) #3
philipj_slow
Philip, can you PTAL? My take on the blink-dev thread is that removal without deprecation ...
6 years, 1 month ago (2014-11-08 22:44:59 UTC) #5
pdr.
On 2014/11/08 at 22:44:59, philipj wrote: > Philip, can you PTAL? My take on the ...
6 years, 1 month ago (2014-11-11 00:14:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681113006/20001
6 years, 1 month ago (2014-11-11 00:15:44 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 00:47:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185081

Powered by Google App Engine
This is Rietveld 408576698