Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: Source/core/dom/Fullscreen.h

Issue 681113006: Remove keyboard event filtering in fullscreen (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: oops Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/ElementFullscreen.idl ('k') | Source/core/dom/Fullscreen.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Fullscreen.h
diff --git a/Source/core/dom/Fullscreen.h b/Source/core/dom/Fullscreen.h
index 9eed71b521c303c678cde753fe50fa727c1a8564..5257fa7f566b89824af57c84f69da7c8f9bccf1d 100644
--- a/Source/core/dom/Fullscreen.h
+++ b/Source/core/dom/Fullscreen.h
@@ -60,9 +60,7 @@ public:
enum RequestType {
UnprefixedRequest, // Element.requestFullscreen()
- PrefixedRequest, // Element.webkitRequestFullscreen()
- PrefixedMozillaRequest, // Element.webkitRequestFullScreen()
- PrefixedMozillaAllowKeyboardInputRequest, // Element.webkitRequestFullScreen(Element.ALLOW_KEYBOARD_INPUT)
+ PrefixedRequest, // Element.webkitRequestFullscreen() and webkitRequestFullScreen()
PrefixedVideoRequest, // HTMLVideoElement.webkitEnterFullscreen() and webkitEnterFullScreen()
};
@@ -83,7 +81,6 @@ public:
void elementRemoved(Element&);
// Mozilla API
- bool webkitFullScreenKeyboardInputAllowed() const { return m_fullScreenElement.get() && m_areKeysEnabledInFullScreen; }
Element* webkitCurrentFullScreenElement() const { return m_fullScreenElement.get(); }
virtual void documentWasDetached() override;
@@ -108,7 +105,6 @@ private:
void enqueueErrorEvent(Element&, RequestType);
void eventQueueTimerFired(Timer<Fullscreen>*);
- bool m_areKeysEnabledInFullScreen;
RefPtrWillBeMember<Element> m_fullScreenElement;
WillBeHeapVector<std::pair<RefPtrWillBeMember<Element>, RequestType> > m_fullScreenElementStack;
RawPtrWillBeMember<RenderFullScreen> m_fullScreenRenderer;
« no previous file with comments | « Source/core/dom/ElementFullscreen.idl ('k') | Source/core/dom/Fullscreen.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698