Fix a bug of sequential focus navigation with <select multiple>, and so on.

Fix a bug of sequential focus navigation with <select multiple>, and so on.

<select multiple>, <select size=2-or-greater>, and <input
type=date/datetime-local/month/time/week> had a bug that they prevented
sequential focus navigation even if they were not focusabble.

Change nextNodeWithGreaterTabIndex() so that it uses adjustedTabIndex().

BUG=425937
TEST=automated

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184877

[tkent, 2014-11-05 06:46:25]

tkent@chromium.org changed reviewers:
+ hayato@chromium.org, keishi@chromium.org, kochi@chromium.org

[tkent, 2014-11-05 06:46:26]

Would you review this please?

[hayato, 2014-11-05 16:41:10]

LGTM

[hayato, 2014-11-05 16:41:17]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2014-11-05 16:41:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/681103003/1

[commit-bot: I haz the power, 2014-11-05 16:43:34]

Committed patchset #1 (id:1) as 184877

[kochi, 2014-11-05 17:33:48]

https://codereview.chromium.org/681103003/diff/1/Source/core/page/FocusContro...
File Source/core/page/FocusController.cpp (right):

https://codereview.chromium.org/681103003/diff/1/Source/core/page/FocusContro...
Source/core/page/FocusController.cpp:552: winningTabIndex = node.tabIndex();
Why this isn't currentTabIndex?

[tkent, 2014-11-05 23:24:00]

https://codereview.chromium.org/681103003/diff/1/Source/core/page/FocusContro...
File Source/core/page/FocusController.cpp (right):

https://codereview.chromium.org/681103003/diff/1/Source/core/page/FocusContro...
Source/core/page/FocusController.cpp:552: winningTabIndex = node.tabIndex();
On 2014/11/05 17:33:48, Takayoshi Kochi wrote:
> Why this isn't currentTabIndex?

I think |currentTabIndex| and |node.tabIndex()| are same in this case.  If
|currentTabIndex| is different from |node.tabIndex()|, the above |if| doesn't
succeed.

Anyway, this is inconsistent with previousNodeWithLowerTabIndex().  I'll post
another CL.

[shariff.khalid, 2014-11-12 12:42:20]

On 2014/11/05 06:46:25, tkent wrote:
> mailto:tkent@chromium.org changed reviewers:
> + mailto:hayato@chromium.org, mailto:keishi@chromium.org,
mailto:kochi@chromium.org

Dear Sir,

I am facing the similar issue on chrome version Version 38.0.2125.122 m
Could you please suggest where is the fix i mean in which build i can download.


Thanks
Khalid

[kochi, 2014-11-12 12:45:49]

On 2014/11/12 12:42:20, shariff.khalid wrote:
> On 2014/11/05 06:46:25, tkent wrote:
> > mailto:tkent@chromium.org changed reviewers:
> > + mailto:hayato@chromium.org, mailto:keishi@chromium.org,
> mailto:kochi@chromium.org
> 
> Dear Sir,
> 
> I am facing the similar issue on chrome version Version 38.0.2125.122 m
> Could you please suggest where is the fix i mean in which build i can
download.
> 
> 
> Thanks
> Khalid

Chrome version 39 which has this fix is expected to be released soon, later this
month.
Please wait for your Chrome to auto-update to version 39.