Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 68093002: Remove duplicated headers from modules/ (Closed)

Created:
7 years, 1 month ago by lgombos
Modified:
7 years, 1 month ago
Reviewers:
eseidel
CC:
blink-reviews, jsbell, philipj_slow, alecflett, Raymond Toy, kinuko, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, dgrogan, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove duplicated headers from the testing/ directory where the implementation file includes the same dependencies as the corresponding primary header. BUG=317231 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -127 lines) Patch
M Source/modules/crypto/CryptoResultImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystem.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystemBase.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DirectoryEntrySync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/EntryBase.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/EntrySync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/FileWriter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/FileWriterSync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/LocalFileSystem.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/Gamepad.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/GamepadList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/geolocation/Geolocation.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBAny.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBCursor.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/IDBFactory.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBIndex.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBKeyRange.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBVersionChangeEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCDataChannelEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCStatsReport.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCStatsRequestImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/quota/WorkerNavigatorStorageQuota.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesis.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/vibration/NavigatorVibration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/modules/webaudio/AudioNodeInput.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioNodeOutput.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioProcessingEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/BiquadDSPKernel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioCompletionEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/PannerNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/PeriodicWave.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/WaveShaperDSPKernel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseAuthorizer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseClient.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseSync.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseTask.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseTracker.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatementBackend.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatementSync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackend.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackendSync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionCoordinator.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/websockets/MainThreadWebSocketChannel.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImpl.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/modules/websockets/WebSocketChannel.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocketHandshake.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lgombos
changes for modules/
7 years, 1 month ago (2013-11-10 18:58:53 UTC) #1
eseidel
lgtm
7 years, 1 month ago (2013-11-11 20:59:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/68093002/1
7 years, 1 month ago (2013-11-11 21:01:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/68093002/1
7 years, 1 month ago (2013-11-12 18:53:13 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 19:40:38 UTC) #5
Message was sent while issue was closed. 
Change committed as 161845

Powered by Google App Engine
This is Rietveld 408576698