Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 680903002: Add skia bindings for VertexAttrib[1f,2fv,3fv]. (Closed)

Created:
6 years, 1 month ago by egdaniel
Modified:
6 years, 1 month ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add skia bindings for VertexAttrib[1f,2fv,3fv]. BUG= Committed: https://crrev.com/b33a8bc87d8d11db3d37d0f1d3ea3bcfa98fd1f5 Cr-Commit-Position: refs/heads/master@{#301435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_skia_in_process.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680903002/1
6 years, 1 month ago (2014-10-27 14:07:54 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-27 14:07:57 UTC) #4
egdaniel
ptal. Thanks
6 years, 1 month ago (2014-10-27 14:10:22 UTC) #6
no sievers
lgtm
6 years, 1 month ago (2014-10-27 19:14:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680903002/1
6 years, 1 month ago (2014-10-27 19:22:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 20:43:58 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 20:44:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b33a8bc87d8d11db3d37d0f1d3ea3bcfa98fd1f5
Cr-Commit-Position: refs/heads/master@{#301435}

Powered by Google App Engine
This is Rietveld 408576698