Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 680833005: MIPS: Add floor, ceil, round (truncate) instructions for ia32, x64 (if SSE4.1) and add floor, ceil,… (Closed)

Created:
6 years, 1 month ago by balazs.kilvady
Modified:
4 years, 11 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Add floor, ceil, round (truncate) instructions for ia32, x64 (if SSE4.1) and add floor, ceil, round (truncate and away from zero) for arm64. Port r25018 (77a5c80) TEST=test/mjsunit/asm/math-floor.js,test/mjsunit/asm/math-ceil.js,test/unittest/compiler/js-builtin-reducer-unittest.cc BUG=

Patch Set 1 #

Patch Set 2 : Remove RoundTiesAway #

Total comments: 1

Patch Set 3 : supported on r6 also. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 3 chunks +27 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
balazs.kilvady
6 years, 1 month ago (2014-10-31 18:49:26 UTC) #2
paul.l...
LGTM.
6 years, 1 month ago (2014-10-31 18:56:49 UTC) #3
dusmil.imgtec
Hmm, just checking are our versions of conversion instruction the same as thous used in ...
6 years, 1 month ago (2014-10-31 19:06:49 UTC) #4
paul.l...
https://codereview.chromium.org/680833005/diff/20001/src/compiler/mips/instruction-selector-mips.cc File src/compiler/mips/instruction-selector-mips.cc (right): https://codereview.chromium.org/680833005/diff/20001/src/compiler/mips/instruction-selector-mips.cc#newcode688 src/compiler/mips/instruction-selector-mips.cc:688: if (CpuFeatures::IsSupported(MIPSr2)) { Per side discussion between me & ...
6 years, 1 month ago (2014-10-31 19:11:40 UTC) #5
dusmil.imgtec
Not good, it looks like this is rounding only which produces double result from double ...
6 years, 1 month ago (2014-10-31 19:12:50 UTC) #6
dusmil.imgtec
6 years, 1 month ago (2014-10-31 19:14:32 UTC) #7
Not good, it looks like this is rounding only which produces double result from
 double input.
 I checked this on ia32. I wish I was wrong. Instructions used in MIPS code will
produce LONG integer.

Powered by Google App Engine
This is Rietveld 408576698