Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 680583002: Revert "Get rid of net::LOAD_ENABLE_UPLOAD_PROGRESS." (Closed)

Created:
6 years, 2 months ago by oshima
Modified:
6 years, 2 months ago
Reviewers:
Lukasz Jagielski
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Get rid of net::LOAD_ENABLE_UPLOAD_PROGRESS." > Get rid of net::LOAD_ENABLE_UPLOAD_PROGRESS. > It's only used by Loader code. > BUG=426442 > > Review URL: https://codereview.chromium.org/669073003 > > Cr-Commit-Position: refs/heads/master@{#301110} TBR=ljagielski@opera.com Reason for revert: This is causing use-of-unititialized-value on msan bots. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Browser%20%281%29/builds/1746/steps/browser_tests/logs/stdio ==29276== WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7fcb9a0f0d17 in content::ResourceLoader::ReportUploadProgress() content/browser/loader/resource_loader.cc:163:9 #1 0x7fcb9a0f3241 in content::ResourceLoader::OnResponseStarted(net::URLRequest*) content/browser/loader/resource_loader.cc:341:3 #2 0x7fcb980bb80f in net::URLRequestJob::NotifyHeadersComplete() net/url_request/url_request_job.cc:376:3 #3 0x7fcb98304f13 in net::URLRequestHttpJob::NotifyHeadersComplete() net/url_request/url_request_http_job.cc:355:3 #4 0x7fcb983080de in net::URLRequestHttpJob::SaveNextCookie() net/url_request/url_request_http_job.cc:692:5 #5 0x7fcb98301b30 in net::URLRequestHttpJob::OnStartCompleted(int) net/url_request/url_request_http_job.cc:848:5 #6 0x7fcb97f1f140 in Run base/callback.h:441:12 #7 0x7fcb97f1f140 in net::HttpCache::Transaction::DoCallback(int) net/http/http_cache_transaction.cc:727:0 #8 0x7fcb97f1ae2f in HandleResult net/http/http_cache_transaction.cc:733:5 #9 0x7fcb97f1ae2f in net::HttpCache::Transaction::DoLoop(int) net/http/http_cache_transaction.cc:994:0 #10 0x7fcb97f185f4 in net::HttpCache::Transaction::OnIOComplete(int) net/http/http_cache_transaction.cc:2955:3 Committed: https://chromium.googlesource.com/chromium/src/+/db286f1acb2466ee4af059c463a86bb66269d7e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -69 lines) Patch
M chrome/test/data/webui/net_internals/log_view_painter.js View 10 chunks +15 lines, -26 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/request_info.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/request_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_request_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/child/request_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/load_flags_list.h View 1 chunk +25 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/db286f1acb2466ee4af059c463a86bb66269d7e8 Cr-Commit-Position: refs/heads/master@{#301139}
6 years, 2 months ago (2014-10-24 17:46:49 UTC) #2
oshima
6 years, 2 months ago (2014-10-24 17:46:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db286f1acb2466ee4af059c463a86bb66269d7e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698