Get rid of net::LOAD_ENABLE_UPLOAD_PROGRESS.

Get rid of net::LOAD_ENABLE_UPLOAD_PROGRESS.

It's only used by Loader code.

BUG=426442
Committed: https://crrev.com/69c091ddba1bddda795eb5da4e400d16b29cc732
Cr-Commit-Position: refs/heads/master@{#301110}

Committed: https://crrev.com/6615c1cc5a503300512accc00c28e4cb5989829e
Cr-Commit-Position: refs/heads/master@{#301843}

[Lukasz Jagielski, 2014-10-22 13:26:36]

ljagielski@opera.com changed reviewers:
+ jam@chromium.org, kenrb@chromium.org, mmenke@chromium.org

[Lukasz Jagielski, 2014-10-22 13:27:52]

Hi,
PTAL at my next attempt to reduce the count of net load flags :)
Best Regards,
Łukasz

[mmenke, 2014-10-22 18:23:37]

https://codereview.chromium.org/669073003/diff/1/chrome/test/data/webui/net_i...
File chrome/test/data/webui/net_internals/log_view_painter.js (right):

https://codereview.chromium.org/669073003/diff/1/chrome/test/data/webui/net_i...
chrome/test/data/webui/net_internals/log_view_painter.js:193:
LoadFlag.VERIFY_EV_CERT;
Great to see this dependency on exact load flag values removed!

https://codereview.chromium.org/669073003/diff/1/content/child/web_url_loader...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/669073003/diff/1/content/child/web_url_loader...
content/child/web_url_loader_impl.cc:449: request_info.enable_upload_progress =
true;
nit:  request_info.enable_upload_progress = request.reportUploadProgress();

https://codereview.chromium.org/669073003/diff/1/content/common/resource_mess...
File content/common/resource_messages.h (right):

https://codereview.chromium.org/669073003/diff/1/content/common/resource_mess...
content/common/resource_messages.h:227: IPC_STRUCT_MEMBER(bool,
enable_upload_progress)
You never seem to be populating this field - you should copy the field from
RequestInfo to ResourceHostMsg_Request in
IPCResourceLoaderBridge::IPCResourceLoaderBridge, right?

The fact that this didn't cause any tests to fail makes me very nervous, or did
you not run any tests?

https://codereview.chromium.org/669073003/diff/1/content/public/child/request...
File content/public/child/request_peer.h (right):

https://codereview.chromium.org/669073003/diff/1/content/public/child/request...
content/public/child/request_peer.h:37: // note: only for requests with upload
progress enabled
nit:  While you're here, this should end in a period.

[Lukasz Jagielski, 2014-10-22 20:23:39]

https://codereview.chromium.org/669073003/diff/1/content/common/resource_mess...
File content/common/resource_messages.h (right):

https://codereview.chromium.org/669073003/diff/1/content/common/resource_mess...
content/common/resource_messages.h:227: IPC_STRUCT_MEMBER(bool,
enable_upload_progress)
On 2014/10/22 18:23:37, mmenke wrote:
> You never seem to be populating this field - you should copy the field from
> RequestInfo to ResourceHostMsg_Request in
> IPCResourceLoaderBridge::IPCResourceLoaderBridge, right?
> 
> The fact that this didn't cause any tests to fail makes me very nervous, or
did
> you not run any tests?

I forgot to add files, I did run tests for which I modified the code. Will I be
able to rerun the trybots?

[mmenke, 2014-10-23 16:38:59]

LGTM.  Could you also update your bug number to be 426442 - I filed a bug for
the reduction of load flags.  Unfortuantely, doesn't look like I can assign it
to you (For tracking who's been working on it, not as a firm commitment).

https://codereview.chromium.org/669073003/diff/20001/content/child/web_url_lo...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/669073003/diff/20001/content/child/web_url_lo...
content/child/web_url_loader_impl.cc:444: ;
While you're here, mind removing this bonus semi-colon?

[jam, 2014-10-23 22:47:25]

lgtm

[kenrb, 2014-10-24 14:25:45]

ipc lgtm

[Lukasz Jagielski, 2014-10-24 15:07:14]

The CQ bit was checked by ljagielski@opera.com

[commit-bot: I haz the power, 2014-10-24 15:07:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669073003/40001

[commit-bot: I haz the power, 2014-10-24 16:05:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-24 16:06:07]

Patchset 3 (id:??) landed as
https://crrev.com/69c091ddba1bddda795eb5da4e400d16b29cc732
Cr-Commit-Position: refs/heads/master@{#301110}

[leviw_travelin_and_unemployed, 2014-10-24 17:54:42]

I'm guessing this is responsible for breaking this layout tests:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...

Is that expected?

[mmenke, 2014-10-24 17:58:41]

On 2014/10/24 17:54:42, leviw wrote:
> I'm guessing this is responsible for breaking this layout tests:
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...
> 
> Is that expected?

No, it's not.  CL should be reverted until we figure out what the issue is.

[mmenke, 2014-10-24 17:59:56]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/680593002/ by mmenke@chromium.org.

The reason for reverting is: This broke the upload-progress-events.html layout
test
(http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...).

[leviw_travelin_and_unemployed, 2014-10-24 18:14:22]

Thanks for the quick response!!

[Lukasz Jagielski, 2014-10-27 08:09:45]

Hi,
I fixed the use of uninitialized value. Is there any try job target that can
help me make sure that I'm not repeating this error again? Sorry for my
clumsiness.
Regards,
Łuksz

[mmenke, 2014-10-27 15:20:32]

On 2014/10/27 08:09:45, Lukasz Jagielski wrote:
> Hi,
> I fixed the use of uninitialized value. Is there any try job target that can
> help me make sure that I'm not repeating this error again? Sorry for my
> clumsiness.
> Regards,
> Łuksz

I've started a couple memory trybots running.  You can try running the failing
layout test locally (Sorry, I can't tell you how to do that - I generally work
at either the network stack layer, or the Chrome layer, and those are run
somewhere in between).

[mmenke, 2014-10-29 14:38:50]

Forgot to check back on this.  The bots don't seem to have detected any other
issues.  LGTM, feel free to try and land again at your convenience.

[Lukasz Jagielski, 2014-10-29 14:52:01]

The CQ bit was checked by ljagielski@opera.com

[commit-bot: I haz the power, 2014-10-29 14:52:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669073003/60001

[Lukasz Jagielski, 2014-10-29 14:54:02]

On 2014/10/29 14:38:50, mmenke wrote:
> Forgot to check back on this.  The bots don't seem to have detected any other
> issues.  LGTM, feel free to try and land again at your convenience.

Thanks! :)

[commit-bot: I haz the power, 2014-10-29 15:49:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-29 15:50:38]

Patchset 4 (id:??) landed as
https://crrev.com/6615c1cc5a503300512accc00c28e4cb5989829e
Cr-Commit-Position: refs/heads/master@{#301843}