Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 6805019: Move crypto files out of base, to a top level directory. (Closed)

Created:
9 years, 8 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
eroman, wtc, bradn, brettw
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, PaweĊ‚ Hajdan Jr., pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move crypto files out of base, to a top level directory. src/crypto is now an independent project that contains our cryptographic primitives (except md5 and sha1). This removes the base dependency from nss, openssl and sqlite. BUG=76996 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81611

Patch Set 1 #

Total comments: 17

Patch Set 2 : '' #

Patch Set 3 : Chrome, webkit, remoting and crypto/owners #

Total comments: 14

Patch Set 4 : '' #

Total comments: 7

Patch Set 5 : Fixes comments by eroman #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10281 lines, -10169 lines) Patch
M base/base.gyp View 1 2 3 5 chunks +0 lines, -15 lines 0 comments Download
M base/base.gypi View 1 2 3 5 chunks +0 lines, -112 lines 0 comments Download
D base/crypto/capi_util.h View 1 2 3 1 chunk +0 lines, -34 lines 0 comments Download
D base/crypto/capi_util.cc View 1 2 3 1 chunk +0 lines, -50 lines 0 comments Download
D base/crypto/crypto_module_blocking_password_delegate.h View 1 2 3 1 chunk +0 lines, -34 lines 0 comments Download
D base/crypto/cssm_init.h View 1 2 3 1 chunk +0 lines, -60 lines 0 comments Download
D base/crypto/cssm_init.cc View 1 2 3 1 chunk +0 lines, -204 lines 0 comments Download
D base/crypto/encryptor.h View 1 2 3 1 chunk +0 lines, -70 lines 0 comments Download
D base/crypto/encryptor_mac.cc View 1 2 3 1 chunk +0 lines, -76 lines 0 comments Download
D base/crypto/encryptor_nss.cc View 1 2 3 1 chunk +0 lines, -125 lines 0 comments Download
D base/crypto/encryptor_openssl.cc View 1 2 3 1 chunk +0 lines, -127 lines 0 comments Download
D base/crypto/encryptor_unittest.cc View 1 2 3 1 chunk +0 lines, -232 lines 0 comments Download
D base/crypto/encryptor_win.cc View 1 2 3 1 chunk +0 lines, -115 lines 0 comments Download
D base/crypto/mac_security_services_lock.h View 1 2 3 1 chunk +0 lines, -22 lines 0 comments Download
D base/crypto/mac_security_services_lock.cc View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
D base/crypto/rsa_private_key.h View 1 2 3 1 chunk +0 lines, -274 lines 0 comments Download
D base/crypto/rsa_private_key.cc View 1 2 3 1 chunk +0 lines, -390 lines 0 comments Download
D base/crypto/rsa_private_key_mac.cc View 1 2 3 1 chunk +0 lines, -196 lines 0 comments Download
D base/crypto/rsa_private_key_nss.cc View 1 2 3 1 chunk +0 lines, -248 lines 0 comments Download
D base/crypto/rsa_private_key_nss_unittest.cc View 1 2 3 1 chunk +0 lines, -64 lines 0 comments Download
D base/crypto/rsa_private_key_openssl.cc View 1 2 3 1 chunk +0 lines, -135 lines 0 comments Download
D base/crypto/rsa_private_key_unittest.cc View 1 2 3 1 chunk +0 lines, -383 lines 0 comments Download
D base/crypto/rsa_private_key_win.cc View 1 2 3 1 chunk +0 lines, -229 lines 0 comments Download
D base/crypto/scoped_capi_types.h View 1 2 3 1 chunk +0 lines, -125 lines 0 comments Download
D base/crypto/scoped_nss_types.h View 1 2 3 1 chunk +0 lines, -52 lines 0 comments Download
D base/crypto/secure_hash.h View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download
D base/crypto/secure_hash_default.cc View 1 2 3 1 chunk +0 lines, -49 lines 0 comments Download
D base/crypto/secure_hash_openssl.cc View 1 2 3 1 chunk +0 lines, -53 lines 0 comments Download
D base/crypto/secure_hash_unittest.cc View 1 2 3 1 chunk +0 lines, -34 lines 0 comments Download
D base/crypto/signature_creator.h View 1 2 3 1 chunk +0 lines, -70 lines 0 comments Download
D base/crypto/signature_creator_mac.cc View 1 2 3 1 chunk +0 lines, -74 lines 0 comments Download
D base/crypto/signature_creator_nss.cc View 1 2 3 1 chunk +0 lines, -76 lines 0 comments Download
D base/crypto/signature_creator_openssl.cc View 1 2 3 1 chunk +0 lines, -54 lines 0 comments Download
D base/crypto/signature_creator_unittest.cc View 1 2 3 1 chunk +0 lines, -53 lines 0 comments Download
D base/crypto/signature_creator_win.cc View 1 2 3 1 chunk +0 lines, -60 lines 0 comments Download
D base/crypto/signature_verifier.h View 1 2 3 1 chunk +0 lines, -109 lines 0 comments Download
D base/crypto/signature_verifier_mac.cc View 1 2 3 1 chunk +0 lines, -105 lines 0 comments Download
D base/crypto/signature_verifier_nss.cc View 1 2 3 1 chunk +0 lines, -113 lines 0 comments Download
D base/crypto/signature_verifier_openssl.cc View 1 2 3 1 chunk +0 lines, -94 lines 0 comments Download
D base/crypto/signature_verifier_unittest.cc View 1 2 3 1 chunk +0 lines, -268 lines 0 comments Download
D base/crypto/signature_verifier_win.cc View 1 2 3 1 chunk +0 lines, -134 lines 0 comments Download
D base/crypto/symmetric_key.h View 1 2 3 1 chunk +0 lines, -105 lines 0 comments Download
D base/crypto/symmetric_key_mac.cc View 1 2 3 1 chunk +0 lines, -155 lines 0 comments Download
D base/crypto/symmetric_key_nss.cc View 1 2 3 1 chunk +0 lines, -127 lines 0 comments Download
D base/crypto/symmetric_key_openssl.cc View 1 2 3 1 chunk +0 lines, -76 lines 0 comments Download
D base/crypto/symmetric_key_unittest.cc View 1 2 3 1 chunk +0 lines, -226 lines 0 comments Download
D base/crypto/symmetric_key_win.cc View 1 2 3 1 chunk +0 lines, -536 lines 0 comments Download
D base/hmac.h View 1 2 3 1 chunk +0 lines, -61 lines 0 comments Download
D base/hmac_mac.cc View 1 2 3 1 chunk +0 lines, -73 lines 0 comments Download
D base/hmac_nss.cc View 1 2 3 1 chunk +0 lines, -117 lines 0 comments Download
D base/hmac_openssl.cc View 1 2 3 1 chunk +0 lines, -57 lines 0 comments Download
D base/hmac_unittest.cc View 1 2 3 1 chunk +0 lines, -236 lines 0 comments Download
D base/hmac_win.cc View 1 2 3 1 chunk +0 lines, -197 lines 0 comments Download
D base/nss_util.h View 1 2 3 1 chunk +0 lines, -137 lines 0 comments Download
D base/nss_util.cc View 1 2 3 1 chunk +0 lines, -704 lines 0 comments Download
D base/nss_util_internal.h View 1 2 3 1 chunk +0 lines, -30 lines 0 comments Download
D base/openssl_util.h View 1 2 3 1 chunk +0 lines, -113 lines 0 comments Download
D base/openssl_util.cc View 1 2 3 1 chunk +0 lines, -113 lines 0 comments Download
M base/sha1_win.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
D base/sha2.h View 1 2 3 1 chunk +0 lines, -35 lines 0 comments Download
D base/sha2.cc View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download
D base/sha2_unittest.cc View 1 2 3 1 chunk +0 lines, -97 lines 0 comments Download
M base/test/test_suite.cc View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download
D base/third_party/nss/LICENSE View 1 2 3 1 chunk +0 lines, -35 lines 0 comments Download
D base/third_party/nss/README.chromium View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
D base/third_party/nss/blapi.h View 1 2 3 1 chunk +0 lines, -101 lines 0 comments Download
D base/third_party/nss/blapit.h View 1 2 3 1 chunk +0 lines, -91 lines 0 comments Download
D base/third_party/nss/sha256.h View 1 2 3 1 chunk +0 lines, -51 lines 0 comments Download
D base/third_party/nss/sha512.cc View 1 2 3 1 chunk +0 lines, -1391 lines 0 comments Download
M chrome/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_main.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_main_gtk.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_main_mac.mm View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_main_win.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/google_authenticator.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/mock_owner_key_utils.h View 1 2 3 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/owner_key_utils.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/owner_key_utils.cc View 1 2 3 6 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/owner_key_utils_unittest.cc View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/owner_manager.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/owner_manager_unittest.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/ownership_service_unittest.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings_unittest.cc View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/base_file.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/base_file.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_creator.h View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_creator.cc View 1 2 3 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/nss_decryptor_system_nss.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/encryptor_linux.cc View 1 2 3 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/password_manager/encryptor_mac.mm View 1 2 3 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/safe_browsing/filter_false_positive_perftest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 2 3 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 1 2 3 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/util/nigori.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/util/nigori.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/crypto_module_password_dialog.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/crypto_module_password_dialog_nss.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/certificate_viewer.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/crypto_module_password_dialog.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/net/x509_certificate_model_nss.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/render_process_impl.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/service/service_process_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/zygote_main_linux.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A crypto/OWNERS View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A crypto/capi_util.h View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A crypto/capi_util.cc View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download
A crypto/crypto.gyp View 1 2 3 4 1 chunk +223 lines, -0 lines 0 comments Download
A crypto/crypto_module_blocking_password_delegate.h View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
A crypto/cssm_init.h View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
A crypto/cssm_init.cc View 1 2 3 1 chunk +204 lines, -0 lines 0 comments Download
A crypto/encryptor.h View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
A crypto/encryptor_mac.cc View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
A crypto/encryptor_nss.cc View 1 2 3 1 chunk +125 lines, -0 lines 0 comments Download
A crypto/encryptor_openssl.cc View 1 2 3 4 1 chunk +127 lines, -0 lines 0 comments Download
A crypto/encryptor_unittest.cc View 1 2 3 1 chunk +233 lines, -0 lines 0 comments Download
A crypto/encryptor_win.cc View 1 2 3 1 chunk +115 lines, -0 lines 0 comments Download
A crypto/hmac.h View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
A crypto/hmac_mac.cc View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
A crypto/hmac_nss.cc View 1 2 3 1 chunk +117 lines, -0 lines 0 comments Download
A crypto/hmac_openssl.cc View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
A crypto/hmac_unittest.cc View 1 2 3 1 chunk +236 lines, -0 lines 0 comments Download
A crypto/hmac_win.cc View 1 2 3 1 chunk +197 lines, -0 lines 0 comments Download
A crypto/mac_security_services_lock.h View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A crypto/mac_security_services_lock.cc View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
A crypto/nss_util.h View 1 2 3 1 chunk +138 lines, -0 lines 0 comments Download
A crypto/nss_util.cc View 1 2 3 1 chunk +706 lines, -0 lines 0 comments Download
A crypto/nss_util_internal.h View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A crypto/openssl_util.h View 1 2 3 1 chunk +113 lines, -0 lines 0 comments Download
A crypto/openssl_util.cc View 1 2 3 1 chunk +113 lines, -0 lines 0 comments Download
A crypto/rsa_private_key.h View 1 2 3 1 chunk +273 lines, -0 lines 0 comments Download
A crypto/rsa_private_key.cc View 1 2 3 1 chunk +390 lines, -0 lines 0 comments Download
A crypto/rsa_private_key_mac.cc View 1 2 3 1 chunk +196 lines, -0 lines 0 comments Download
A crypto/rsa_private_key_nss.cc View 1 2 3 1 chunk +248 lines, -0 lines 0 comments Download
A crypto/rsa_private_key_nss_unittest.cc View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download
A crypto/rsa_private_key_openssl.cc View 1 2 3 4 1 chunk +135 lines, -0 lines 0 comments Download
A crypto/rsa_private_key_unittest.cc View 1 2 3 1 chunk +386 lines, -0 lines 0 comments Download
A crypto/rsa_private_key_win.cc View 1 2 3 1 chunk +229 lines, -0 lines 0 comments Download
A crypto/run_all_unittests.cc View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A crypto/scoped_capi_types.h View 1 2 3 1 chunk +125 lines, -0 lines 0 comments Download
A crypto/scoped_nss_types.h View 1 2 3 4 1 chunk +52 lines, -0 lines 0 comments Download
A crypto/secure_hash.h View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A crypto/secure_hash_default.cc View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
A crypto/secure_hash_openssl.cc View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
A crypto/secure_hash_unittest.cc View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
A crypto/sha2.h View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A crypto/sha2.cc View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A crypto/sha2_unittest.cc View 1 2 3 1 chunk +100 lines, -0 lines 0 comments Download
A crypto/signature_creator.h View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
A crypto/signature_creator_mac.cc View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download
A crypto/signature_creator_nss.cc View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
A crypto/signature_creator_openssl.cc View 1 2 3 4 1 chunk +54 lines, -0 lines 0 comments Download
A crypto/signature_creator_unittest.cc View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
A crypto/signature_creator_win.cc View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
A crypto/signature_verifier.h View 1 2 3 1 chunk +108 lines, -0 lines 0 comments Download
A crypto/signature_verifier_mac.cc View 1 2 3 1 chunk +105 lines, -0 lines 0 comments Download
A crypto/signature_verifier_nss.cc View 1 2 3 1 chunk +113 lines, -0 lines 0 comments Download
A crypto/signature_verifier_openssl.cc View 1 2 3 4 1 chunk +94 lines, -0 lines 0 comments Download
A crypto/signature_verifier_unittest.cc View 1 2 3 1 chunk +268 lines, -0 lines 0 comments Download
A crypto/signature_verifier_win.cc View 1 2 3 1 chunk +134 lines, -0 lines 0 comments Download
A crypto/symmetric_key.h View 1 2 3 1 chunk +104 lines, -0 lines 0 comments Download
A crypto/symmetric_key_mac.cc View 1 2 3 1 chunk +155 lines, -0 lines 0 comments Download
A crypto/symmetric_key_nss.cc View 1 2 3 1 chunk +127 lines, -0 lines 0 comments Download
A crypto/symmetric_key_openssl.cc View 1 2 3 4 1 chunk +76 lines, -0 lines 0 comments Download
A crypto/symmetric_key_unittest.cc View 1 2 3 1 chunk +225 lines, -0 lines 0 comments Download
A crypto/symmetric_key_win.cc View 1 2 3 1 chunk +536 lines, -0 lines 0 comments Download
A crypto/third_party/nss/LICENSE View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A crypto/third_party/nss/README.chromium View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A crypto/third_party/nss/blapi.h View 1 2 3 1 chunk +101 lines, -0 lines 0 comments Download
A crypto/third_party/nss/blapit.h View 1 2 3 1 chunk +91 lines, -0 lines 0 comments Download
A crypto/third_party/nss/sha256.h View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A crypto/third_party/nss/sha512.cc View 1 2 3 1 chunk +1391 lines, -0 lines 0 comments Download
M net/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M net/base/cert_database_mac.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/cert_database_nss.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M net/base/cert_database_nss_unittest.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M net/base/dnssec_chain_verifier.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/dnssec_keyset.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/dnssec_keyset.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M net/base/keygen_handler.h View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M net/base/keygen_handler.cc View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M net/base/keygen_handler_mac.cc View 1 2 3 12 chunks +20 lines, -20 lines 0 comments Download
M net/base/keygen_handler_nss.cc View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M net/base/keygen_handler_openssl.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M net/base/keygen_handler_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/keygen_handler_win.cc View 1 2 3 5 chunks +10 lines, -9 lines 0 comments Download
M net/base/openssl_memory_private_key_store.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M net/base/run_all_unittests.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/sdch_manager.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/test_root_certs_nss.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/test_root_certs_openssl.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/transport_security_state.cc View 1 2 3 5 chunks +9 lines, -9 lines 0 comments Download
M net/base/x509_certificate.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/x509_certificate_mac.cc View 1 2 3 7 chunks +12 lines, -12 lines 0 comments Download
M net/base/x509_certificate_nss.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M net/base/x509_certificate_openssl.cc View 1 2 3 8 chunks +11 lines, -11 lines 0 comments Download
M net/base/x509_certificate_unittest.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M net/base/x509_certificate_win.cc View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M net/http/des.cc View 1 2 3 6 chunks +8 lines, -8 lines 0 comments Download
M net/net.gyp View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M net/socket/dns_cert_provenance_checker.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M net/socket/nss_ssl_util.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 2 3 11 chunks +11 lines, -11 lines 0 comments Download
M net/socket/ssl_server_socket.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_server_socket_nss.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/ssl_server_socket_nss.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M net/third_party/mozilla_security_manager/nsKeygenHandler.cpp View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M net/third_party/mozilla_security_manager/nsNSSCertificateDB.cpp View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/host_key_pair.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/host_key_pair.cc View 1 2 3 5 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/keygen_main.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/simple_host_process.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_session.h View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/jingle_session_manager.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/protocol_test_client.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M webkit/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
rvargas (doing something else)
This is not complete, but it's probably better if you start taking a look now ...
9 years, 8 months ago (2011-04-06 22:02:38 UTC) #1
wtc
LGTM. Thanks a lot for writing this CL. I've wanted to do this for a ...
9 years, 8 months ago (2011-04-07 05:35:53 UTC) #2
wtc
rvargas: can you add an OWNERS file to the crypto directory? You can list you, ...
9 years, 8 months ago (2011-04-08 19:09:17 UTC) #3
rvargas (doing something else)
Sure... do you want the file to block looking at the parent directory? On Fri, ...
9 years, 8 months ago (2011-04-08 19:19:54 UTC) #4
wtc
On 2011/04/08 19:19:54, rvargas wrote: > Sure... do you want the file to block looking ...
9 years, 8 months ago (2011-04-08 19:53:47 UTC) #5
rvargas (doing something else)
Thanks. I addressed all the comments, added the owners file and a bunch of other ...
9 years, 8 months ago (2011-04-08 21:04:07 UTC) #6
wtc
crypto/OWNERS looks good to me. http://codereview.chromium.org/6805019/diff/1/base/nss_util.h File base/nss_util.h (left): http://codereview.chromium.org/6805019/diff/1/base/nss_util.h#oldcode88 base/nss_util.h:88: Time PRTimeToBaseTime(int64 prtime); Thank ...
9 years, 8 months ago (2011-04-08 21:14:18 UTC) #7
eroman
sure, i can take this over in wtc's absence. let me know when it is ...
9 years, 8 months ago (2011-04-08 21:37:15 UTC) #8
bradn
http://codereview.chromium.org/6805019/diff/12032/crypto/crypto.gyp File crypto/crypto.gyp (right): http://codereview.chromium.org/6805019/diff/12032/crypto/crypto.gyp#newcode210 crypto/crypto.gyp:210: 8], This might be bad.
9 years, 8 months ago (2011-04-12 21:28:50 UTC) #9
rvargas (doing something else)
http://codereview.chromium.org/6805019/diff/12032/crypto/crypto.gyp File crypto/crypto.gyp (right): http://codereview.chromium.org/6805019/diff/12032/crypto/crypto.gyp#newcode210 crypto/crypto.gyp:210: 8], On 2011/04/12 21:28:50, bradn wrote: > This might ...
9 years, 8 months ago (2011-04-12 22:03:04 UTC) #10
rvargas (doing something else)
Eric: Patch set 4 should pass all tests (just rebased from every test passing). Unfortunately, ...
9 years, 8 months ago (2011-04-13 01:51:58 UTC) #11
eroman
LGTM. Two general suggestions: (1) You may want to grep for 'base/crypto' to verify everything ...
9 years, 8 months ago (2011-04-13 03:25:22 UTC) #12
rvargas (doing something else)
Thanks for the review. Brett: I'm touching some DEPS files and stuff inside src/content. Could ...
9 years, 8 months ago (2011-04-13 19:55:55 UTC) #13
brettw
9 years, 8 months ago (2011-04-13 20:22:44 UTC) #14
content LGTM

Powered by Google App Engine
This is Rietveld 408576698