crypto/run_all_unittests.cc - Issue 6805019: Move crypto files out of base, to a top level directory.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: crypto/run_all_unittests.cc

Issue 6805019: Move crypto files out of base, to a top level directory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/test/test_suite.h"	5 #include "base/test/test_suite.h"

	6 #include "crypto/nss_util.h"

6	7

7 int main(int argc, char** argv) {	8 int main(int argc, char** argv) {

	9 #if defined(USE_NSS)

	10 crypto::EnsureNSSInit();
	wtc 2011/04/07 05:35:53 Why is this necessary? Is this copied from base/t Why is this necessary? Is this copied from base/test/test_suite.cc? Please add a comment to explain. rvargas (doing something else) 2011/04/08 21:04:07 Yes this comes from base, but base is not testing Show quoted text On 2011/04/07 05:35:53, wtc wrote: > Why is this necessary? Is this copied from > base/test/test_suite.cc? > > Please add a comment to explain. Yes this comes from base, but base is not testing crypto code anymore. Instead, this crypto_unittests should make sure that the library is initialized. Note that base_unittests used to perform this in another place
	11 #endif // defined(USE_NSS)

	12

8 return base::TestSuite(argc, argv).Run();	13 return base::TestSuite(argc, argv).Run();

9 }	14 }

OLD	NEW