Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 680493002: Revert "Script streaming: Add an option to make the main thread block (wait for parsing)" (Closed)

Created:
6 years, 2 months ago by marja
Modified:
6 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert "Script streaming: Add an option to make the main thread block (wait for parsing)" This reverts r184277. Reason: ASSERTS fail in debug mode because ScriptStreamer gets destroyed while holding the mutex. BUG= TBR=marja@chromium.org, haraken@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -137 lines) Patch
M Source/bindings/core/v8/ScriptStreamer.h View 5 chunks +3 lines, -19 lines 0 comments Download
M Source/bindings/core/v8/ScriptStreamer.cpp View 9 chunks +23 lines, -74 lines 0 comments Download
M Source/bindings/core/v8/ScriptStreamerTest.cpp View 11 chunks +8 lines, -15 lines 0 comments Download
M Source/bindings/core/v8/ScriptStreamerThread.cpp View 1 chunk +3 lines, -1 line 0 comments Download
D Source/bindings/core/v8/ScriptStreamingMode.h View 1 chunk +0 lines, -25 lines 0 comments Download
M Source/bindings/core/v8/v8.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/Settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
marja
haraken, fyi, I'm reverting this; the mutex dance needs more massaging.
6 years, 2 months ago (2014-10-24 11:41:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680493002/1
6 years, 2 months ago (2014-10-24 11:42:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 184349
6 years, 2 months ago (2014-10-24 11:42:59 UTC) #5
haraken
6 years, 2 months ago (2014-10-24 13:30:15 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698