Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: Source/bindings/core/v8/ScriptStreamerThread.cpp

Issue 680493002: Revert "Script streaming: Add an option to make the main thread block (wait for parsing)" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptStreamerTest.cpp ('k') | Source/bindings/core/v8/ScriptStreamingMode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptStreamerThread.cpp
diff --git a/Source/bindings/core/v8/ScriptStreamerThread.cpp b/Source/bindings/core/v8/ScriptStreamerThread.cpp
index 16fe74231ec2232c339d031c571947389eba9f28..c706ad118476d4be1e4377f8998a0f749693d065 100644
--- a/Source/bindings/core/v8/ScriptStreamerThread.cpp
+++ b/Source/bindings/core/v8/ScriptStreamerThread.cpp
@@ -67,7 +67,9 @@ void ScriptStreamingTask::run()
// Running the task can and will block: SourceStream::GetSomeData will get
// called and it will block and wait for data from the network.
m_v8Task->Run();
- m_streamer->streamingCompleteOnBackgroundThread();
+ // Post a task to the main thread to signal that V8 has completed the
+ // streaming.
+ callOnMainThread(WTF::bind(&ScriptStreamer::streamingComplete, m_streamer));
ScriptStreamerThread::shared()->taskDone();
}
« no previous file with comments | « Source/bindings/core/v8/ScriptStreamerTest.cpp ('k') | Source/bindings/core/v8/ScriptStreamingMode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698