Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 680423003: Fix type analysis of the keyword "dynamic". (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix type analysis of the keyword "dynamic". The type of "dynamic" isn't "dynamic", it's "Type". BUG=dartbug.com/18731 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M tests/language/first_class_types_literals_test.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +5 lines, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-04 02:06:55 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-04 02:22:31 UTC) #3
Paul Berry
6 years, 1 month ago (2014-11-04 04:13:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41477 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698