Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: ui/aura/window_unittest.cc

Issue 680413006: Re-enable Eager Gesture Recognition on Aura (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add DCHECK. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/window_unittest.cc
diff --git a/ui/aura/window_unittest.cc b/ui/aura/window_unittest.cc
index d28df608dfc0c57831c077802e0e2f0fa96a4732..bee49c118f8c44b93ef771fdbb6296740f66a81d 100644
--- a/ui/aura/window_unittest.cc
+++ b/ui/aura/window_unittest.cc
@@ -824,13 +824,13 @@ TEST_F(WindowTest, TouchCaptureCancelsOtherTouches) {
delegate1.ResetCounts();
delegate2.ResetCounts();
- // Events now go to w2.
+ // Events are now untargetted.
sadrul 2014/12/03 21:30:11 Why?
tdresser 2014/12/05 16:44:31 Window 2 sees an invalid touch event stream (a mov
sadrul 2014/12/07 17:25:44 I was under the impression that existing GR sequen
tdresser 2014/12/08 14:49:30 We do transfer gesture sequences sometimes, but (I
ui::TouchEvent move(ui::ET_TOUCH_MOVED, gfx::Point(10, 20), 0, getTime());
DispatchEventUsingWindowDispatcher(&move);
EXPECT_EQ(0, delegate1.gesture_event_count());
EXPECT_EQ(0, delegate1.touch_event_count());
EXPECT_EQ(0, delegate2.gesture_event_count());
- EXPECT_EQ(1, delegate2.touch_event_count());
+ EXPECT_EQ(0, delegate2.touch_event_count());
ui::TouchEvent release(
ui::ET_TOUCH_RELEASED, gfx::Point(10, 20), 0, getTime());

Powered by Google App Engine
This is Rietveld 408576698