Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 680413004: [Password Generation] Send onchange event when password is filled (Closed)

Created:
6 years, 1 month ago by Garrett Casto
Modified:
6 years, 1 month ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Send onchange event when password is filled Failure to do so causes UI issues on some sites, and causes form submission to fail on Yahoo. BUG=159043 Committed: https://crrev.com/dfef9806fea030778404f9bea5d78ed313c31816 Cr-Commit-Position: refs/heads/master@{#302510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M chrome/renderer/autofill/password_generation_agent_browsertest.cc View 3 chunks +29 lines, -1 line 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Garrett Casto
6 years, 1 month ago (2014-11-03 08:11:14 UTC) #2
vabr (Chromium)
LGTM
6 years, 1 month ago (2014-11-03 08:51:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680413004/1
6 years, 1 month ago (2014-11-03 21:58:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 23:06:15 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 23:06:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfef9806fea030778404f9bea5d78ed313c31816
Cr-Commit-Position: refs/heads/master@{#302510}

Powered by Google App Engine
This is Rietveld 408576698