Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: components/autofill/content/renderer/password_generation_agent.cc

Issue 680413004: [Password Generation] Send onchange event when password is filled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/autofill/password_generation_agent_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_generation_agent.cc
diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc
index 48acba0b5ba6ca995b69557f008316e441444f8d..147b773ef51b2a7b52ef0789c40efe12b0fecc79 100644
--- a/components/autofill/content/renderer/password_generation_agent.cc
+++ b/components/autofill/content/renderer/password_generation_agent.cc
@@ -97,7 +97,7 @@ void CopyValueToAllInputElements(
std::vector<blink::WebInputElement>* elements) {
for (std::vector<blink::WebInputElement>::iterator it = elements->begin();
it != elements->end(); ++it) {
- it->setValue(value);
+ it->setValue(value, true /* sendEvents */);
}
}
@@ -256,7 +256,7 @@ void PasswordGenerationAgent::OnPasswordAccepted(
for (std::vector<blink::WebInputElement>::iterator it =
password_elements_.begin();
it != password_elements_.end(); ++it) {
- it->setValue(password);
+ it->setValue(password, true /* sendEvents */);
it->setAutofilled(true);
// Advance focus to the next input field. We assume password fields in
// an account creation form are always adjacent.
« no previous file with comments | « chrome/renderer/autofill/password_generation_agent_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698